Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead links in documentation #198

Closed
zmknox opened this issue Feb 11, 2022 · 4 comments
Closed

Dead links in documentation #198

zmknox opened this issue Feb 11, 2022 · 4 comments
Labels

Comments

@zmknox
Copy link

zmknox commented Feb 11, 2022

Describe the Bug

Some links out to examples on how to utilize this project seem to go to files that no longer exist in this project.

Such as here: https://github.com/openzipkin/zipkin-gcp#example-integrating-stackdriver-storage
where the example links to https://github.com/openzipkin/zipkin-gcp/blob/master/autoconfigure/storage-stackdriver#quick-start , which doesn't exist.

And here: https://github.com/openzipkin/zipkin-gcp/tree/master/docker#stackdriver
which links to https://github.com/openzipkin/zipkin-gcp/blob/master/module/storage-stackdriver#configuration , which doesn't exist.

@zmknox zmknox added the bug label Feb 11, 2022
@yuriatgoogle
Copy link

+1, I was looking for instructions on how to configure Zipkin to send traces to Cloud Trace and hit the same issues.

@jcchavezs
Copy link
Contributor

jcchavezs commented Mar 5, 2022 via email

@codefromthecrypt
Copy link
Member

the easiest way is docker as it is pre-assembled https://github.com/openzipkin/zipkin-gcp/tree/master/docker#running
next is to assemble your own https://github.com/openzipkin/zipkin-gcp/tree/master/docker#running

I'll fix the README in a sec

@codefromthecrypt
Copy link
Member

@zmknox @yuriatgoogle sorry no one took any action on this. #212 should both fix the links and make the build break if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants