Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Span.timestamp/duration #10

Closed
codefromthecrypt opened this issue Aug 7, 2016 · 1 comment
Closed

Support Span.timestamp/duration #10

codefromthecrypt opened this issue Aug 7, 2016 · 1 comment

Comments

@codefromthecrypt
Copy link
Member

Recent versions of the zipkin thrift have the fields Span.timestamp and duration. Particularly in the case of client spans, we can set an authoritative start, with duration accurate to microseconds. This would start by updating the model to the latest thrift (or re-using zipkin's core library)

https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift
codefromthecrypt pushed a commit to openzipkin/zipkin-dependencies that referenced this issue Aug 7, 2016
Fixes Cassandra, which didn't link when raw spans lacked timestamp
b5348c4 
See openzipkin/zipkin#1217
See openzipkin/zipkin-js#29
See openzipkin/zipkin-finagle#10
@codefromthecrypt codefromthecrypt mentioned this issue Aug 7, 2016
Merged
codefromthecrypt pushed a commit that referenced this issue Aug 9, 2016
Sets timestamp and duration authoritatively
c1e8047 
Fixes #10
@codefromthecrypt codefromthecrypt mentioned this issue Aug 9, 2016
Merged
codefromthecrypt pushed a commit that referenced this issue Aug 10, 2016
@adriancole
Sets timestamp and duration authoritatively (#14)
59cf265 
Fixes #10
codefromthecrypt pushed a commit to openzipkin-attic/zipkin-sparkstreaming that referenced this issue Feb 9, 2017
@naoman
Adds initial Finagle Adjuster
a21c46e 
This fixes up spans reported by [Finagle](https://github.com/twitter/finagle/tree/develop/finagle-zipkin).

Adjustment code should not be added without a tracking issue either in
[Finagle](https://github.com/twitter/finagle/issues) or [Zipkin Finagle](https://github.com/openzipkin/zipkin-finagle/issues).

FinagleAdjuster can be used as a library, where attributes are set via
`FinagleAdjuster.Builder`.

It is more commonly enabled with Spring via autoconfiguration when
"zipkin.sparkstreaming.adjuster.finagle.enabled" is set to "true"

Here are the relevant setting and a short description. Properties all
have a prefix of "zipkin.sparkstreaming.adjuster.finagle"

Attribute | Property | Description | Fix
--- | --- | --- | ---
applyTimestampAndDuration | apply-timestamp-and-duration | Backfill span.timestamp and duration based on annotations. Defaults to true | [Use zipkin-finagle](openzipkin/zipkin-finagle#10)
codefromthecrypt pushed a commit to openzipkin-attic/zipkin-sparkstreaming that referenced this issue Feb 9, 2017
@naoman
Adds initial Finagle Adjuster
aa1d13b 
This fixes up spans reported by [Finagle](https://github.com/twitter/finagle/tree/develop/finagle-zipkin).

Adjustment code should not be added without a tracking issue either in
[Finagle](https://github.com/twitter/finagle/issues) or [Zipkin Finagle](https://github.com/openzipkin/zipkin-finagle/issues).

FinagleAdjuster can be used as a library, where attributes are set via
`FinagleAdjuster.Builder`.

It is more commonly enabled with Spring via autoconfiguration when
"zipkin.sparkstreaming.adjuster.finagle.enabled" is set to "true"

Here are the relevant setting and a short description. Properties all
have a prefix of "zipkin.sparkstreaming.adjuster.finagle"

Attribute | Property | Description | Fix
--- | --- | --- | ---
applyTimestampAndDuration | apply-timestamp-and-duration | Backfill span.timestamp and duration based on annotations. Defaults to true | [Use zipkin-finagle](openzipkin/zipkin-finagle#10)
@codefromthecrypt codefromthecrypt mentioned this issue Feb 9, 2017
Merged
codefromthecrypt pushed a commit to openzipkin-attic/zipkin-sparkstreaming that referenced this issue Feb 9, 2017
@naoman
Adds initial Finagle Adjuster
4bbb14e 
This fixes up spans reported by [Finagle](https://github.com/twitter/finagle/tree/develop/finagle-zipkin).

Adjustment code should not be added without a tracking issue either in
[Finagle](https://github.com/twitter/finagle/issues) or [Zipkin Finagle](https://github.com/openzipkin/zipkin-finagle/issues).

FinagleAdjuster can be used as a library, where attributes are set via
`FinagleAdjuster.Builder`.

It is more commonly enabled with Spring via autoconfiguration when
"zipkin.sparkstreaming.adjuster.finagle.enabled" is set to "true"

Here are the relevant setting and a short description. Properties all
have a prefix of "zipkin.sparkstreaming.adjuster.finagle"

Attribute | Property | Description | Fix
--- | --- | --- | ---
applyTimestampAndDuration | apply-timestamp-and-duration | Backfill span.timestamp and duration based on annotations. Defaults to true | [Use zipkin-finagle](openzipkin/zipkin-finagle#10)
codefromthecrypt pushed a commit to openzipkin-attic/zipkin-sparkstreaming that referenced this issue Feb 10, 2017
Adds initial Finagle Adjuster
308916a 
This fixes up spans reported by [Finagle](https://github.com/twitter/finagle/tree/develop/finagle-zipkin).

Adjustment code should not be added without a tracking issue either in
[Finagle](https://github.com/twitter/finagle/issues) or [Zipkin Finagle](https://github.com/openzipkin/zipkin-finagle/issues).

FinagleAdjuster can be used as a library, where attributes are set via
`FinagleAdjuster.Builder`.

It is more commonly enabled with Spring via autoconfiguration when
"zipkin.sparkstreaming.adjuster.finagle.enabled" is set to "true"

Here are the relevant setting and a short description. Properties all
have a prefix of "zipkin.sparkstreaming.adjuster.finagle"

Attribute | Property | Description | Fix
--- | --- | --- | ---
applyTimestampAndDuration | apply-timestamp-and-duration | Backfill span.timestamp and duration based on annotations. Defaults to true | [Use zipkin-finagle](openzipkin/zipkin-finagle#10)
codefromthecrypt pushed a commit to openzipkin-attic/zipkin-sparkstreaming that referenced this issue Feb 10, 2017
@adriancole
Adds initial Finagle Adjuster (#6)
40d8d47 
This fixes up spans reported by [Finagle](https://github.com/twitter/finagle/tree/develop/finagle-zipkin).

Adjustment code should not be added without a tracking issue either in
[Finagle](https://github.com/twitter/finagle/issues) or [Zipkin Finagle](https://github.com/openzipkin/zipkin-finagle/issues).

FinagleAdjuster can be used as a library, where attributes are set via
`FinagleAdjuster.Builder`.

It is more commonly enabled with Spring via autoconfiguration when
"zipkin.sparkstreaming.adjuster.finagle.enabled" is set to "true"

Here are the relevant setting and a short description. Properties all
have a prefix of "zipkin.sparkstreaming.adjuster.finagle"

Attribute | Property | Description | Fix
--- | --- | --- | ---
applyTimestampAndDuration | apply-timestamp-and-duration | Backfill span.timestamp and duration based on annotations. Defaults to true | [Use zipkin-finagle](openzipkin/zipkin-finagle#10)
@naoman naoman mentioned this issue Mar 13, 2017
Closed
@codefromthecrypt codefromthecrypt mentioned this issue Mar 16, 2017
Closed
@codefromthecrypt
Copy link
Member Author

I noticed I added comments on the wrong issue.. will raise in zipkin-sparkstreaming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt