This repository has been archived by the owner on Apr 3, 2018. It is now read-only.
Adds initial Finagle Adjuster #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
finagle-adjustment
branch
from
aa1d13b to
4bbb14e
Compare
Closed
This fixes up spans reported by [Finagle](https://github.com/twitter/finagle/tree/develop/finagle-zipkin). Adjustment code should not be added without a tracking issue either in [Finagle](https://github.com/twitter/finagle/issues) or [Zipkin Finagle](https://github.com/openzipkin/zipkin-finagle/issues). FinagleAdjuster can be used as a library, where attributes are set via `FinagleAdjuster.Builder`. It is more commonly enabled with Spring via autoconfiguration when "zipkin.sparkstreaming.adjuster.finagle.enabled" is set to "true" Here are the relevant setting and a short description. Properties all have a prefix of "zipkin.sparkstreaming.adjuster.finagle" Attribute | Property | Description | Fix --- | --- | --- | --- applyTimestampAndDuration | apply-timestamp-and-duration | Backfill span.timestamp and duration based on annotations. Defaults to true | [Use zipkin-finagle](openzipkin/zipkin-finagle#10)
codefromthecrypt
force-pushed
the
finagle-adjustment
branch
from
4bbb14e to
308916a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up spans reported by Finagle.
Adjustment code should not be added without a tracking issue either in
Finagle or Zipkin Finagle.
FinagleAdjuster can be used as a library, where attributes are set via
FinagleAdjuster.Builder.It is more commonly enabled with Spring via autoconfiguration when
"zipkin.sparkstreaming.adjuster.finagle.enabled" is set to "true"
Here are the relevant setting and a short description. Properties all
have a prefix of "zipkin.sparkstreaming.adjuster.finagle"