Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts to dummy response instead of a compile dep on google's empty #64

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Reverts to dummy response instead of a compile dep on google's empty #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
144b291
Reverts to dummy response instead of a compile dep on google's empty
Apr 23, 2019
ff5c842
removes redundant namespacing too
adriancole Apr 23, 2019
5a7fef8
revised text
Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions zipkin.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

syntax = "proto3";

import "google/protobuf/empty.proto";

package zipkin.proto3;

// In Java, the closest model type to this proto is in the "zipkin2" package
Expand Down Expand Up @@ -215,6 +213,11 @@ message ListOfSpans {
repeated Span spans = 1;
}

// Response for SpanService/Report RPC. This response currently does not return
// any information beyond indicating that the request has finished. That said,
// it may be extended in the future.
message ReportResponse {
}

// SpanService allows reporting spans using gRPC, as opposed to HTTP POST
// reporting. Implementations are asynchronous and may drop spans for reasons
Expand All @@ -226,5 +229,5 @@ service SpanService {
// Report the provided spans to the collector. Analogous to the HTTP POST
// /api/v2/spans endpoint. Spans are not required to be complete or belonging
// to the same trace.
rpc Report(zipkin.proto3.ListOfSpans) returns (google.protobuf.Empty) {}
rpc Report(ListOfSpans) returns (ReportResponse) {}
}