Reverts to dummy response instead of a compile dep on google's empty #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty is the only thing that requires a compile dependency on google (not standard proto) types. For example, if you use square wire compiler, you need to add a google library now to compile our proto. Since we haven't really released the service, yet, and empty is binary compatible with an equally empty response, we can change. This reverts to what @ewhauser had originally, which makes things more portable.
5 tasks
anuraaga
approved these changes
Apr 23, 2019
zipkin.proto
Outdated
| @@ -215,6 +213,10 @@ message ListOfSpans { | |||
| repeated Span spans = 1; | |||
| } | |||
|
|
|||
| // Response for SpanService/Report RPC. This response currently does not return | |||
| // any information beyond indicating that the request has finished. | |||
There was a problem hiding this comment.
Can consider adding , but may be extended in the future if the flexibility might help later
There was a problem hiding this comment.
sounds fine to me
codefromthecrypt
pushed a commit
to ewhauser/zipkin
that referenced
this pull request
Apr 25, 2019
codefromthecrypt
pushed a commit
to ewhauser/zipkin
that referenced
this pull request
Apr 25, 2019
codefromthecrypt
pushed a commit
to ewhauser/zipkin
that referenced
this pull request
Apr 25, 2019
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Apr 25, 2019
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty is the only thing that requires a compile dependency on google
(not standard proto) types. For example, if you use square wire
compiler, you need to add a google library now to compile our proto.
Since we haven't really released the service, yet, and empty is binary
compatible with an equally empty response, we can change.
This reverts to what @ewhauser had originally, which makes things
more portable.