Data model #17
Merged
Data model #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adriancole how do you feel about this in its current state? |
| Spans must be transported from the services being traced to Zipkin collectors. | ||
| There are two primary transports, Scribe and Kafka. Scribe is deprecated. | ||
| Spans sent by the instrumented library must be transported from the services being traced to Zipkin collectors. | ||
| There are two primary transports: Scribe and Kafka. Scribe is shown in the figure. See [Span Receivers]({{ site.github.url }}/pages/span_receivers) for more information. |
There was a problem hiding this comment.
HTTP is also a primary transport
|
LGTM thanks! |
abesto
pushed a commit
that referenced
this pull request
Jun 16, 2019
Adds sources download information for all projects except Brave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a stab at converting the #11 into something helpful. Let me know if there are other "key insights" that we should highlight for the user. It doesn't seem to be helpful to explain to the user how we created the JSON, so I didn't explain that. If you disagree, we obviously can. :)
*** this includes the changes in #14 . do not merge unless you want to make everything live.