Final edits #14
Merged
Final edits #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,17 +6,17 @@ weight: 0 | |||
|  | |||
|
|
|||
| Zipkin is a distributed tracing system. It helps gather timing data needed to | |||
| troubleshoot latency problems in microservice architectures. It manages both the | |||
| troubleshoot latency problems in micro-service architectures. It manages both the | |||
There was a problem hiding this comment.
microservice is more commonly used than micro-service https://en.wikipedia.org/wiki/Microservices
|
Hi, there. I know I made comments, but please don't lose hope :) The documentation site was forklifted and needs a lot of refactoring. You can choose how much of that you feel up to, and any amount will be very appreciated. |
|
ps added a note about packaging as it relates to why we don't need zipkin-web anymore (spoiler, it is hosted on the same process as the api, most typically) #15 |
Merged
| request back to the client. The difference between this and `ss` will be the | ||
| amount of time it took the server to process the request. | ||
| * **cr** - Client Recieve. The client has received the response from the server. | ||
| * **cr** - Client Receiver: The client has received the response from the server. |
|
some unimportant nits. thanks for offering follow-up changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed flow of architecture page and added transition text.
added link in Architecture page to Span Receivers page (I hope!)
minor updates throughout
-simplified language