Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

【FIX】fix revisionHistoryLimit is not exist #54

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

JameKeal
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

When I deploy yurt-app-manager, and the cluster is also have some uniteddeployment, the yurt-app-manager is not run success, the error is:
image
image

The reason is ud.Spec.RevisionHistoryLimit is not exist, but the code use it's pointer to get the value.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

When I deploy yurt-app-manager, and the cluster is also have some uniteddeployment, the yurt-app-manager is not run success, the error is:
image
image

The reason is ud.Spec.RevisionHistoryLimit is not exist, but the code use it's pointer to get the value.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label May 16, 2022
@openyurt-bot openyurt-bot added the approved approved label Aug 22, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JameKeal, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved approved lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants