fix revisionHistoryLimit is not exist (#54)

openyurtio · Aug 22, 2022 · 69c860f · 69c860f
1 parent c5cabf9
commit 69c860f
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/yurtappmanager/controller/uniteddeployment/revision.go b/pkg/yurtappmanager/controller/uniteddeployment/revision.go
@@ -153,7 +153,11 @@ func (r *ReconcileUnitedDeployment) constructUnitedDeploymentRevisions(ud *appsa
 func (r *ReconcileUnitedDeployment) cleanExpiredRevision(ud *appsalphav1.UnitedDeployment,
 	sortedRevisions *[]*apps.ControllerRevision) (*[]*apps.ControllerRevision, error) {
 
-	exceedNum := len(*sortedRevisions) - int(*ud.Spec.RevisionHistoryLimit)
+	var revisionHistoryLimit int
+	if ud.Spec.RevisionHistoryLimit != nil {
+		revisionHistoryLimit = int(*ud.Spec.RevisionHistoryLimit)
+	}
+	exceedNum := len(*sortedRevisions) - revisionHistoryLimit
 	if exceedNum <= 0 {
 		return sortedRevisions, nil
 	}