Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

improve the coverage of yurtappset #113

Merged
merged 1 commit into from
Aug 26, 2022
Merged

improve the coverage of yurtappset #113

merged 1 commit into from
Aug 26, 2022

Conversation

River-sh
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind enhancement

What this PR does / why we need it:

This PR enriches unit testing of the Yurtappset controller and improves test coverage.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@River-sh: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind enhancement

What this PR does / why we need it:

This PR enriches unit testing of the Yurtappset controller and improves test coverage.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot requested review from kadisi and zzguang August 26, 2022 07:31
@openyurt-bot
Copy link
Collaborator

Welcome @River-sh! It looks like this is your first PR to openyurtio/yurt-app-manager 🎉

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #113 (1550680) into master (0e8bf4d) will increase coverage by 10.88%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #113       +/-   ##
===========================================
+ Coverage   26.42%   37.31%   +10.88%     
===========================================
  Files          42       42               
  Lines        4776     4776               
===========================================
+ Hits         1262     1782      +520     
+ Misses       3344     2754      -590     
- Partials      170      240       +70     
Flag Coverage Δ
unittests 37.31% <ø> (+10.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...manager/controller/nodepool/nodepool_controller.go 56.75% <0.00%> (-1.02%) ⬇️
...ager/controller/yurtappset/adapter/adapter_util.go 65.62% <0.00%> (+40.62%) ⬆️
...ntroller/yurtappset/adapter/statefulset_adapter.go 41.87% <0.00%> (+41.87%) ⬆️
...ger/controller/yurtappset/yurtappset_controller.go 48.16% <0.00%> (+47.24%) ⬆️
...manager/controller/yurtappset/yurtappset_update.go 48.27% <0.00%> (+48.27%) ⬆️
...g/yurtappmanager/controller/yurtappset/revision.go 49.21% <0.00%> (+49.21%) ⬆️
...ntroller/yurtappset/yurtappset_controller_utils.go 60.00% <0.00%> (+60.00%) ⬆️
...rtappmanager/controller/yurtappset/pool_control.go 60.74% <0.00%> (+60.74%) ⬆️
...ontroller/yurtappset/adapter/deployment_adapter.go 66.66% <0.00%> (+66.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the approved approved label Aug 26, 2022
@openyurt-bot openyurt-bot added the lgtm lgtm label Aug 26, 2022
@openyurt-bot openyurt-bot merged commit 10967c7 into openyurtio:master Aug 26, 2022
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, River-sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

Fixes #74

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants