-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
@River-sh: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @River-sh! It looks like this is your first PR to openyurtio/yurt-app-manager 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
===========================================
+ Coverage 26.42% 37.31% +10.88%
===========================================
Files 42 42
Lines 4776 4776
===========================================
+ Hits 1262 1782 +520
+ Misses 3344 2754 -590
- Partials 170 240 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, River-sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #74 |
What type of PR is this?
What this PR does / why we need it:
This PR enriches unit testing of the Yurtappset controller and improves test coverage.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note