Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

[unit test] improve unit test coverage for yurtappset #74

Closed
rambohe-ch opened this issue Jul 20, 2022 · 4 comments
Closed

[unit test] improve unit test coverage for yurtappset #74

rambohe-ch opened this issue Jul 20, 2022 · 4 comments
Assignees
@River-sh
Labels
kind/feature kind/feature

Comments

@rambohe-ch
Copy link
Member

What would you like to be added:
improve unit test coverage for yurtappset controller:

target coverage: 70%

Why is this needed:
improve unit test coverage for OpenYurt project.

others
/kind feature
@rambohe-ch rambohe-ch added the kind/feature kind/feature label Jul 20, 2022
@luc99hen luc99hen removed their assignment Jul 22, 2022
@River-sh
Copy link
Contributor

/assign

@Congrool
Copy link
Member

Congrool commented Jul 25, 2022 •
edited
Loading

We commented yurtappset_controller_test.go under pkg/yurtappmanager/controller/yurtappset in pr #72. We'd better take care of it in this pr.

@rambohe-ch
Copy link
Member Author

rambohe-ch commented Jul 26, 2022 •
edited
Loading

We commented yurtappset_controller_test.go under pkg/yurtappmanager/controller/yurtappset in pr #72. We'd better take care of it in this pr.

@River-sh FYI

@rambohe-ch rambohe-ch mentioned this issue Aug 30, 2022
Merged
@rambohe-ch
Copy link
Member Author

Fixes by #113

@rambohe-ch rambohe-ch moved this to Done in controlplane-v1.0 Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@River-sh River-sh

Labels
kind/feature kind/feature
Projects
No open projects
controlplane-v1.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@luc99hen @Congrool @rambohe-ch @River-sh