Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodepool governance capability proposal #772

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

Peeknut
Copy link
Member

@Peeknut Peeknut commented Mar 7, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Peeknut: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Mar 7, 2022
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Mar 7, 2022
@rambohe-ch
Copy link
Member

@Peeknut please fix the markdown check errors.

@rambohe-ch
Copy link
Member

@Peeknut according to the name votes in issue #786 , pool-coordinator will be used as name for the new component name. please rename pool-spirit as pool-coordinator in this proposal.

@Peeknut
Copy link
Member Author

Peeknut commented Apr 7, 2022

@Peeknut according to the name votes in issue #786 , pool-coordinator will be used as name for the new component name. please rename pool-spirit as pool-coordinator in this proposal.

down

@Peeknut Peeknut force-pushed the master branch 2 times, most recently from a3db78a to 7084f2e Compare April 7, 2022 09:08
@openyurt-bot openyurt-bot added the approved approved label Apr 8, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Peeknut, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadisi kadisi removed the lgtm lgtm label Apr 11, 2022
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Apr 11, 2022
@openyurt-bot openyurt-bot merged commit 251e493 into openyurtio:master Apr 11, 2022
@rambohe-ch
Copy link
Member

Fixes #738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants