Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]NodePool Governance Capability: Add component pool-coordinator #777

Closed
Peeknut opened this issue Mar 10, 2022 · 10 comments · Fixed by openyurtio/yurt-app-manager#126
Assignees
Labels

Comments

@Peeknut
Copy link
Member

Peeknut commented Mar 10, 2022

What would you like to be added:
pool-coordinator uses apiserver and etcd in a pod mode, and etcd needs to use memory storage. Its life cycle is controlled by YurtAppDaemon, and helm charts of pool-coordinator will be prepared . So the following work needs to be done:

Before implementation, the following tests are required:

  • When there are many resources in the NodePool (500 Nodes, 1k Pods), whether etcd, which stores resources in memory, can work normally.
  • When there are many resources in the NodePool (500 Nodes, 1k Pods), whether the node's leader election through etcd can work normally.

You can try to build an etcd with data stored in memory in the following ways: https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/doc/demo.md

If there is a problem with the test, please comment and discuss. If there is no problem with the test, in order to implement pool-coordinator, the following work needs to be done:

  • After pool-coordinator starts, it is required to prepare clusterrolebinding associated with view rights in the kube-apiserver. This ensures that kubectl tool in NodePool can successfully get/list data using kubeconfig certificate.
  • Provide the image of pool-coordinator and related documents for deploying pool-coordinator.

Notes: For details, please refer to the proposal: #772

Why is this needed:
As mentioned in the proposal(#772), pool-coordinator provides operation and maintenance functions and autonomous functions for NodePool. It is the core component.

others
/kind feature

@Peeknut Peeknut added the kind/feature kind/feature label Mar 10, 2022
@donychen1134
Copy link
Contributor

/assign donychen1134

@donychen1134
Copy link
Contributor

donychen1134 commented Apr 8, 2022

"You can try to build an etcd with data stored in memory in the following ways: https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/doc/demo.md"
Whether this doc link is wrong? I can't find any "build an etcd with data stored in memory" information in the web page.
Maybe I can use the follow way to let etcd data store in memory:

  volumes:
  - emptyDir:
      medium: Memory
    name: etcd-data

@rambohe-ch
Copy link
Member

"You can try to build an etcd with data stored in memory in the following ways: https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/main/virtualcluster/doc/demo.md" Whether this doc link is wrong? I can't find any "build an etcd with data stored in memory" information in the web page. Maybe I can use the follow way to let etcd data store in memory:

  volumes:
  - emptyDir:
      medium: Memory
    name: etcd-data

@donychen1134 yes, use emptyDir volume for etcd data.

@donychen1134
Copy link
Contributor

progress update:

  1. Use opensource apiserver and etcd image to generate pool-coordinator yaml file. Done
  2. Test the basic apiserver CRUD. Done
  3. Performance test. Doing

@stale
Copy link

stale bot commented Aug 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 30, 2022
@rambohe-ch
Copy link
Member

/label pinned

@stale stale bot removed the wontfix label Sep 1, 2022
@rambohe-ch rambohe-ch moved this to In Progress in controlplane-v1.2 Nov 15, 2022
@rambohe-ch rambohe-ch changed the title [feature request]NodePool Governance Capability: Add component pool-spirit [feature request]NodePool Governance Capability: Add component pool-coordinator Nov 28, 2022
@donychen1134
Copy link
Contributor

/close

@openyurt-bot
Copy link
Collaborator

@donychen1134: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

/close

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-project-automation github-project-automation bot moved this from In Progress to Done in controlplane-v1.2 Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants