bump controller-gen to v0.13.0 #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
Congrool
force-pushed
the
bump-controllergen
branch
from
0e9e851 to
6b9ae3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2056 +/- ##
==========================================
- Coverage 55.63% 55.62% -0.02%
==========================================
Files 186 186
Lines 18079 18079
==========================================
- Hits 10058 10056 -2
- Misses 6998 6999 +1
- Partials 1023 1024 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/rerun |
Congrool
force-pushed
the
bump-controllergen
branch
2 times, most recently
from
183bd76 to
3f55b8a
Compare
Congrool
changed the title
|
/rerun |
1 similar comment
|
/rerun |
|
/unhold |
|
@rambohe-ch PTAL Not sure if this can make the github release workflow run successfully, at least it works around at my host. |
Signed-off-by: Congrool <[email protected]>
Congrool
force-pushed
the
bump-controllergen
branch
from
3f55b8a to
73dead4
Compare
|
rambohe-ch
approved these changes
May 27, 2024
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Since we align the openyurt with kubernetes 1.28 in #2047, we should also bump the
controller-gento a newer version to avoid compatibility problem whose current version is v0.7.0 which is a bit stale.controller-genhelp us automatically generate code for CRDs. We've encountered the situation that the automatic generation cannot be done in release action.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note