-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix work dir nested yurthub/yurthub
#1693
Conversation
@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
02bc52f
to
5d8d39d
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
- Coverage 51.66% 51.64% -0.03%
==========================================
Files 145 163 +18
Lines 17011 19748 +2737
==========================================
+ Hits 8788 10198 +1410
- Misses 7407 8595 +1188
- Partials 816 955 +139
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@rambohe-ch fixed |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luc99hen, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
…fix_calico * 'master' of https://github.com/openyurtio/openyurt: Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702) fix: add the logic of removing the finalizer (openyurtio#1695) Fix work dir nested `yurthub/yurthub` (openyurtio#1693) Add yurtappoverrider (openyurtio#1684) modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689) chore: slice loop replace (openyurtio#1690) unified expression about DaemonSet (openyurtio#1698) improve controller names (openyurtio#1687) add gateway public service controller (openyurtio#1685) feat: add token format checking to yurtadm join process (openyurtio#1681) add gateway internal service controller (openyurtio#1677) fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679) unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
What type of PR is this?
What this PR does / why we need it:
We expect Yurthub's workdir to be
/var/lib/yurthub
. Currently, it is set to/var/lib/yurthub/yurthub
becauseoptions.RootDir=/var/lib/yurthub
by default, which is misleading for end users.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note