Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unserve v1alpha1 version of platformadmin crd #1659

Merged

Conversation

LavenderQAQ
Copy link
Member

What type of PR is this?

/kind enhancement
/sig iot

What this PR does / why we need it:

Let users use the more complete version of v1alpha2.

Which issue(s) this PR fixes:

Fixes #1656

Does this PR introduce a user-facing change?

Please use the v1alpha2 version of platformadmin, which is much more complete than v1alpha1.

@openyurt-bot openyurt-bot added do-not-merge/work-in-progress do-not-merge/work-in-progress kind/enhancement kind/enhancement labels Aug 16, 2023
@LavenderQAQ LavenderQAQ marked this pull request as ready for review August 16, 2023 07:55
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Aug 16, 2023
@LavenderQAQ
Copy link
Member Author

This pr needs to wait for #1650 to merge first.

@LavenderQAQ
Copy link
Member Author

/hold

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Aug 16, 2023
@LavenderQAQ LavenderQAQ force-pushed the feat/remove-platformadmin-v1alpha1 branch from 4035d25 to f39428d Compare August 22, 2023 07:23
@LavenderQAQ
Copy link
Member Author

/unhold

@openyurt-bot openyurt-bot removed the do-not-merge/hold do-not-merge/hold label Aug 22, 2023
@LavenderQAQ
Copy link
Member Author

/assign @Rui-Gan @wangxye

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: GitHub didn't allow me to assign the following users: wangxye, Rui-Gan.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @Rui-Gan @wangxye

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1659 (adeeaa9) into master (68d4079) will not change coverage.
The diff coverage is n/a.

❗ Current head adeeaa9 differs from pull request most recent head 1be5a24. Consider uploading reports for the commit 1be5a24 to get more accurate results

@@           Coverage Diff           @@
##           master    #1659   +/-   ##
=======================================
  Coverage   52.79%   52.79%           
=======================================
  Files         160      160           
  Lines       18725    18725           
=======================================
  Hits         9886     9886           
  Misses       7928     7928           
  Partials      911      911           
Flag Coverage Δ
unittests 52.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@LavenderQAQ LavenderQAQ force-pushed the feat/remove-platformadmin-v1alpha1 branch from f39428d to 33f2f4e Compare August 25, 2023 09:54
@openyurt-bot openyurt-bot added size/XS size/XS: 0-9 and removed size/XXL labels Aug 25, 2023
@LavenderQAQ LavenderQAQ force-pushed the feat/remove-platformadmin-v1alpha1 branch from 33f2f4e to adeeaa9 Compare August 26, 2023 23:59
@LavenderQAQ LavenderQAQ changed the title feat: remove v1alpha1 version of platformadmin crd feat: unserve v1alpha1 version of platformadmin crd Aug 27, 2023
@LavenderQAQ LavenderQAQ force-pushed the feat/remove-platformadmin-v1alpha1 branch from adeeaa9 to 1be5a24 Compare August 27, 2023 00:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zyjhtangtang
Copy link
Contributor

/lgtm

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Aug 30, 2023
@openyurt-bot openyurt-bot merged commit a7d29d6 into openyurtio:master Aug 30, 2023
luckymrwang added a commit to luckymrwang/openyurt that referenced this pull request Sep 20, 2023
…fix_calico

* 'master' of https://github.com/openyurtio/openyurt:
  Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702)
  fix: add the logic of removing the finalizer (openyurtio#1695)
  Fix work dir nested `yurthub/yurthub` (openyurtio#1693)
  Add yurtappoverrider (openyurtio#1684)
  modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689)
  chore: slice loop replace (openyurtio#1690)
  unified expression about DaemonSet (openyurtio#1698)
  improve controller names (openyurtio#1687)
  add gateway public service controller (openyurtio#1685)
  feat: add token format checking to yurtadm join process (openyurtio#1681)
  add gateway internal service controller (openyurtio#1677)
  fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679)
  unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
@LavenderQAQ LavenderQAQ deleted the feat/remove-platformadmin-v1alpha1 branch January 30, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm sig/iot sig/iot size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Unserve version alpha1 of platformadmin crd
4 participants