Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade YurtIoTDock to support edgex v3 api #1666

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

wangxye
Copy link
Member

@wangxye wangxye commented Aug 21, 2023

What type of PR is this?

/sig iot
/kind feature
/kind bug

What this PR does / why we need it:

Upgrade the api to keep up with the new version of edgex v3.

Which issue(s) this PR fixes:

Fixes #1615 and #1627

Does this PR introduce a user-facing change?

cat <<EOF | kubectl apply -f -
apiVersion: iot.openyurt.io/v1alpha2
kind: PlatformAdmin
metadata:
  name: edgex-sample
spec:
  version: minnesota
  poolName: beijing
  components:
    - name: edgex-ui
    - name: edgex-device-rest
    - name: edgex-device-virtual
    - name: yurt-iot-dock
EOF

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 26 Code Smells

No Coverage information No Coverage information
6.4% 6.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #1666 (eb67cee) into master (b6f2ec0) will increase coverage by 0.70%.
The diff coverage is 67.47%.

@@            Coverage Diff             @@
##           master    #1666      +/-   ##
==========================================
+ Coverage   52.32%   53.03%   +0.70%     
==========================================
  Files         154      158       +4     
  Lines       17637    18504     +867     
==========================================
+ Hits         9228     9813     +585     
- Misses       7582     7796     +214     
- Partials      827      895      +68     
Flag Coverage Δ
unittests 53.03% <67.47%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tiotdock/clients/edgex-foundry/v2/device_client.go 56.41% <ø> (ø)
...k/clients/edgex-foundry/v2/deviceprofile_client.go 56.81% <ø> (ø)
...k/clients/edgex-foundry/v2/deviceservice_client.go 56.07% <ø> (ø)
pkg/yurtiotdock/clients/edgex-foundry/v2/util.go 92.19% <ø> (ø)
pkg/yurtiotdock/controllers/util/string.go 17.64% <0.00%> (-82.36%) ⬇️
...k/clients/edgex-foundry/v3/deviceservice_client.go 56.07% <56.07%> (ø)
...tiotdock/clients/edgex-foundry/v3/device_client.go 56.41% <56.41%> (ø)
...k/clients/edgex-foundry/v3/deviceprofile_client.go 56.81% <56.81%> (ø)
pkg/yurtiotdock/clients/edgex-foundry/v3/util.go 89.91% <89.91%> (ø)

@wangxye
Copy link
Member Author

wangxye commented Aug 21, 2023

/assign @LavenderQAQ @Rui-Gan

Copy link
Member

@LavenderQAQ LavenderQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

@LavenderQAQ: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LavenderQAQ, rambohe-ch, wangxye

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Upgrade YurtIoTDock to support edgex v3 api
4 participants