-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change access permission to default in general. #1576
change access permission to default in general. #1576
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
replacement of #1574 |
@YTGhost could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i found the else where that set the permission into 0600
but if those are dedicated files for OpenYurt, that should be fine since those can be managed by OpenYurt only.
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
==========================================
+ Coverage 51.35% 51.43% +0.07%
==========================================
Files 134 134
Lines 15947 15947
==========================================
+ Hits 8190 8202 +12
+ Misses 7011 7000 -11
+ Partials 746 745 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@rambohe-ch This change may require backport for each release, PTAL. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fujitatomoya, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/approve |
@rambohe-ch @YTGhost quick question, how can we monitor or track the backport for each release? |
@fujitatomoya I will backport this pull request to OpenYurt v1.0 ~ v1.3 |
/backport release-v1.3 |
/backport release-v1.2 |
/backport release-v1.1 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
/backport release-v1.0 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
Successfully created backport PR for |
Git push to origin failed for release-v1.2 with exitcode 1 |
Successfully created backport PR for |
Successfully created backport PR for |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
1 similar comment
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
Git push to origin failed for release-v1.2 with exitcode 1 |
Git push to origin failed for release-v1.3 with exitcode 1 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
Git push to origin failed for release-v1.2 with exitcode 1 |
Git push to origin failed for release-v1.3 with exitcode 1 |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6 |
@fujitatomoya It seems that this pull request can be backported to v1.2 and v1.3, because there are conflicts in v1.0 and v1.1. so i will only backport this pull request to v1.2 and v1.3. If you want to this pull request can be merged into v1.1 and v1.0, please make another new pull request for branch release-v1.0 and releasze-v1.1. |
@fujitatomoya OpenYurt v1.3.3 is released, and this pull request is included in this version. by the way, you can get the yurtadm v1.3.3 in the following link: |
backport of openyurtio#1576 for release-v1.1 Signed-off-by: Tomoya Fujita <[email protected]>
backport of openyurtio#1576 for release-v1.0 Signed-off-by: Tomoya Fujita <[email protected]>
fix is straight forward, can you help review and merge for each release version?
|
backport of #1576 for release-v1.0 Signed-off-by: Tomoya Fujita <[email protected]>
backport of #1576 for release-v1.1 Signed-off-by: Tomoya Fujita <[email protected]>
What type of PR is this?
/kind bug
address #1573
What this PR does / why we need it:
It does use the default file access permission.
/opt/cni/bin
tomoyafujita@~ >ls -lt /opt/cni/ total 4.0K drwxr-xr-x 2 root root 4.0K Jun 9 15:43 bin/
/etc/systemd/system/kubelet.service.d/10-kubeadm.conf
tomoyafujita@~ >ls -lt /etc/systemd/system/kubelet.service.d/10-kubeadm.conf -rw-r----- 1 root root 898 Sep 21 2022 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
Which issue(s) this PR fixes:
Fixes #1573
Special notes for your reviewer: