Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change access permission to default in general. #1576

Conversation

fujitatomoya
Copy link
Contributor

What type of PR is this?

/kind bug

address #1573

What this PR does / why we need it:

It does use the default file access permission.

  • /opt/cni/bin
tomoyafujita@~ >ls -lt /opt/cni/
total 4.0K
drwxr-xr-x 2 root root 4.0K Jun  9 15:43 bin/
  • /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
tomoyafujita@~ >ls -lt /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
-rw-r----- 1 root root 898 Sep 21  2022 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf

Which issue(s) this PR fixes:

Fixes #1573

Special notes for your reviewer:

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Jun 30, 2023
@openyurt-bot openyurt-bot requested review from DrmagicE and Peeknut June 30, 2023 18:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jun 30, 2023
@fujitatomoya
Copy link
Contributor Author

replacement of #1574

@fujitatomoya
Copy link
Contributor Author

@YTGhost could you take a look?

Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i found the else where that set the permission into 0600 but if those are dedicated files for OpenYurt, that should be fine since those can be managed by OpenYurt only.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #1576 (95ba3a7) into master (f9d8025) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1576      +/-   ##
==========================================
+ Coverage   51.35%   51.43%   +0.07%     
==========================================
  Files         134      134              
  Lines       15947    15947              
==========================================
+ Hits         8190     8202      +12     
+ Misses       7011     7000      -11     
+ Partials      746      745       -1     
Flag Coverage Δ
unittests 51.43% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@YTGhost
Copy link
Member

YTGhost commented Jul 1, 2023

@rambohe-ch This change may require backport for each release, PTAL.

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fujitatomoya, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

/approve

@openyurt-bot openyurt-bot added the approved approved label Jul 2, 2023
@openyurt-bot openyurt-bot merged commit 211cb4f into openyurtio:master Jul 2, 2023
@fujitatomoya
Copy link
Contributor Author

@rambohe-ch @YTGhost quick question, how can we monitor or track the backport for each release?

@rambohe-ch
Copy link
Member

@rambohe-ch @YTGhost quick question, how can we monitor or track the backport for each release?

@fujitatomoya I will backport this pull request to OpenYurt v1.0 ~ v1.3

@rambohe-ch rambohe-ch added backport release-v1.0 backport release-v1.0 backport release-v1.2 backport release-v1.2 backport release-v1.3 backport release-v1.3 backport release-v1.1 labels Jul 4, 2023
@rambohe-ch
Copy link
Member

/backport release-v1.3

@rambohe-ch
Copy link
Member

/backport release-v1.2

@rambohe-ch
Copy link
Member

/backport release-v1.1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

@rambohe-ch
Copy link
Member

/backport release-v1.0

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Successfully created backport PR for release-v1.2:

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.2 with exitcode 1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Successfully created backport PR for release-v1.3:

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Successfully created backport PR for release-v1.3:

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.2 with exitcode 1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.3 with exitcode 1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.0
git worktree add -d .worktree/backport-1576-to-release-v1.0 origin/release-v1.0
cd .worktree/backport-1576-to-release-v1.0
git checkout -b backport-1576-to-release-v1.0
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.2 with exitcode 1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Git push to origin failed for release-v1.3 with exitcode 1

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Backport failed for release-v1.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-v1.1
git worktree add -d .worktree/backport-1576-to-release-v1.1 origin/release-v1.1
cd .worktree/backport-1576-to-release-v1.1
git checkout -b backport-1576-to-release-v1.1
ancref=$(git merge-base f9d80259680cbeb2e46e173bd3f45c057e69c7cc 95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6)
git cherry-pick -x $ancref..95ba3a72fd07cf79bcf772c1f068dbb88bdfb5e6

@rambohe-ch
Copy link
Member

@fujitatomoya It seems that this pull request can be backported to v1.2 and v1.3, because there are conflicts in v1.0 and v1.1. so i will only backport this pull request to v1.2 and v1.3.

If you want to this pull request can be merged into v1.1 and v1.0, please make another new pull request for branch release-v1.0 and releasze-v1.1.

@rambohe-ch
Copy link
Member

@fujitatomoya OpenYurt v1.3.3 is released, and this pull request is included in this version.

by the way, you can get the yurtadm v1.3.3 in the following link:
https://github.com/openyurtio/openyurt/releases/tag/v1.3.3

fujitatomoya added a commit to fujitatomoya/openyurt that referenced this pull request Jul 10, 2023
  backport of openyurtio#1576 for release-v1.1

Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya added a commit to fujitatomoya/openyurt that referenced this pull request Jul 10, 2023
  backport of openyurtio#1576 for release-v1.0

Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Contributor Author

@YTGhost @rambohe-ch

If you want to this pull request can be merged into v1.1 and v1.0, please make another new pull request for branch release-v1.0 and releasze-v1.1.

fix is straight forward, can you help review and merge for each release version?

rambohe-ch pushed a commit that referenced this pull request Jul 11, 2023
backport of #1576 for release-v1.0

Signed-off-by: Tomoya Fujita <[email protected]>
rambohe-ch pushed a commit that referenced this pull request Jul 11, 2023
backport of #1576 for release-v1.1

Signed-off-by: Tomoya Fujita <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved backport release-v1.0 backport release-v1.0 backport release-v1.1 backport release-v1.2 backport release-v1.2 backport release-v1.3 backport release-v1.3 kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] yurtadm tries to set the incorrect permission, which leads to unexpected failure
4 participants