-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set file system permission via yurtadm to default #1574
set file system permission via yurtadm to default #1574
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
…ccess permission. Signed-off-by: Tomoya Fujita <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fujitatomoya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think same fixes can be applied to master branch as well. if we should fix that on master branch and backporting the fix for each release, that i can help with.
Yes, we should fix that on master branch and backporting the fix for each release. And maybe you should submit the PR to the master branch, and then after merge we can have github-action automatically backport it via the backport command |
@YTGhost okay that is what i though. my concern was that backport would not be straight-forward since there is huge difference between anyway, i understand the procedure, fix will be resubmitted targeted to master branch. |
What type of PR is this?
/kind bug
address #1573
What this PR does / why we need it:
It does use the default file access permission.
/opt/cni/bin
tomoyafujita@~ >ls -lt /opt/cni/ total 4.0K drwxr-xr-x 2 root root 4.0K Jun 9 15:43 bin/
/etc/systemd/system/kubelet.service.d/10-kubeadm.conf
tomoyafujita@~ >ls -lt /etc/systemd/system/kubelet.service.d/10-kubeadm.conf -rw-r----- 1 root root 898 Sep 21 2022 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
Which issue(s) this PR fixes:
Fixes #1573
Special notes for your reviewer:
v1.1.0
, current target to set so. I am happy to address master if you guys want me to do so, then we can backport the fix for each release.