Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set file system permission via yurtadm to default #1574

Conversation

fujitatomoya
Copy link
Contributor

What type of PR is this?

/kind bug

address #1573

What this PR does / why we need it:

It does use the default file access permission.

  • /opt/cni/bin
tomoyafujita@~ >ls -lt /opt/cni/
total 4.0K
drwxr-xr-x 2 root root 4.0K Jun  9 15:43 bin/
  • /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
tomoyafujita@~ >ls -lt /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
-rw-r----- 1 root root 898 Sep 21  2022 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf

Which issue(s) this PR fixes:

Fixes #1573

Special notes for your reviewer:

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Jun 28, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fujitatomoya
To complete the pull request process, please assign yixingjia
You can assign the PR to them by writing /assign @yixingjia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jun 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think same fixes can be applied to master branch as well. if we should fix that on master branch and backporting the fix for each release, that i can help with.

@YTGhost
Copy link
Member

YTGhost commented Jun 29, 2023

I think same fixes can be applied to master branch as well. if we should fix that on master branch and backporting the fix for each release, that i can help with.

Yes, we should fix that on master branch and backporting the fix for each release. And maybe you should submit the PR to the master branch, and then after merge we can have github-action automatically backport it via the backport command

@fujitatomoya
Copy link
Contributor Author

@YTGhost okay that is what i though.

my concern was that backport would not be straight-forward since there is huge difference between master and v1.1.0.

anyway, i understand the procedure, fix will be resubmitted targeted to master branch.

@fujitatomoya
Copy link
Contributor Author

@YTGhost i will go ahead to close this one since i created the replacement #1576 targeted to master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug size/XS size/XS: 0-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants