-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix conflicts for getting node by local storage in yurthub filters #1552
Conversation
@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
==========================================
+ Coverage 50.85% 51.23% +0.38%
==========================================
Files 133 133
Lines 15852 15740 -112
==========================================
+ Hits 8062 8065 +3
+ Misses 7045 6936 -109
+ Partials 745 739 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4380cfb
to
1ef7e11
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
@JameKeal: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
1 similar comment
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadisi, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
As described in pull request optimize yurthub kubelet node cache operator #1461 , filter servicetoplogy and nodeisolation have conflicts for getting node from local storage, and filter can not work well.
After diving into the code of these two filters, we found that node resource is used for resolving node pool, and as discussed in the issue: [feature request]can not move node to another nodepool by label modification #1382 and pull request feat: prevent node movement by label modification #1444 , node pool name for a node can not be changed after joining into the cluster.
at the same time, node pool name can be passed into yurthub by
yurtadm join
command, the detail info can be found in the pull request: add yurtadm join node in specified nodepool #1402 , so we just use node pool name or get node from kube-apiserver only once when node pool name is not passed byyurtadm join
. then we can remove all the codes of getting node from local storage, and solve the conflicts problem.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note