feat: prevent node movement by label modification #1444
Conversation
|
@y-ykcir: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #1444 +/- ##
==========================================
+ Coverage 51.42% 51.43% +0.01%
==========================================
Files 134 134
Lines 15947 15947
==========================================
+ Hits 8200 8202 +2
+ Misses 7001 7000 -1
+ Partials 746 745 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
y-ykcir
force-pushed
the
feat-nodepool-label
branch
from
4402c99 to
9cb1ae6
Compare
|
/hold |
|
/unhold |
|
@y-ykcir please fix github action's errors. |
|
@rambohe-ch It seems that in e2e testing, the nodepool, yurtappdaemon, and yurtappset tests will remove nodes from the nodepool by deleting the NodePoolLabel at the beginning and end of each test. Should we modify such behavior in e2e to use join command and is there any obstacle to do this? |
@y-ykcir would you like to have to try to improve e2e tests? but i think that |
|
@y-ykcir I think we only need to make sure at the same time, we don't need to verify |
y-ykcir
force-pushed
the
feat-nodepool-label
branch
2 times, most recently
from
738a3df to
1576da0
Compare
|
SonarCloud Quality Gate failed.
|
|
@rambohe-ch The code logic has been simplified. Is it possible to add reset and join way in the Kind cluster? If it's not feasible, I am currently thinking of the following handling methods:
|
Signed-off-by: ricky <[email protected]>
y-ykcir
force-pushed
the
feat-nodepool-label
branch
from
1576da0 to
d30e94f
Compare
Signed-off-by: ricky <[email protected]>
y-ykcir
force-pushed
the
feat-nodepool-label
branch
from
d30e94f to
e97f990
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rambohe-ch, y-ykcir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1382
Special notes for your reviewer:
add a validation webhook for node:
user can not change
apps.openyurt.io/desired-nodepoolif node has been added in noodpooluser can not change
apps.openyurt.io/nodepooldirectly, only yurt-manger can change this labelDoes this PR introduce a user-facing change?
other Note