Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support yurt-manager work in specified namespace #1367

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

y-ykcir
Copy link
Member

@y-ykcir y-ykcir commented Apr 13, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

support yurt-manager deploy in specified namespace:
support Gateway controller and Yurt-manager webhooks

Which issue(s) this PR fixes:

Fixes parts of #1361

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@y-ykcir: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

support yurt-manager deploy in specified namespace:
support Gateway controller and Yurt-manager webhooks

Which issue(s) this PR fixes:

Fixes parts of #1361

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1367 (4bbeaca) into master (4f62983) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   52.31%   52.29%   -0.02%     
==========================================
  Files         103      103              
  Lines       12963    12966       +3     
==========================================
  Hits         6781     6781              
- Misses       5629     5632       +3     
  Partials      553      553              
Flag Coverage Δ
unittests 52.29% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/controller/gateway/gateway/gateway_controller.go 22.83% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@y-ykcir
Copy link
Member Author

y-ykcir commented Apr 13, 2023

It looks like the test use yurt-manager-auto-generated.yaml directly to install components here. If I change webhooks.clientConfig.service.namespace to be rendered through helm intead of hardcode, it cannot be used directly.

@rambohe-ch
Copy link
Member

It looks like the test use yurt-manager-auto-generated.yaml directly to install components here. If I change webhooks.clientConfig.service.namespace to be rendered through helm intead of hardcode, it cannot be used directly.

@y-ykcir Very appreciate for your work, it is not need to modify charts/openyurt/templates/yurt-manager-auto-generated.yaml file, because namespace in yurt-manager-auto-generated.yaml file will be overwritten in yurt-manager with working namespace, the detail code is here:
https://github.com/openyurtio/openyurt/blob/master/pkg/webhook/util/configuration/configuration.go#L68
https://github.com/openyurtio/openyurt/blob/master/pkg/webhook/util/configuration/configuration.go#L93

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Apr 13, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, y-ykcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Apr 13, 2023
@openyurt-bot openyurt-bot merged commit 9918229 into openyurtio:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants