Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] support yurt-manager work in specified namespace #1361

Closed
4 tasks done
y-ykcir opened this issue Apr 10, 2023 · 9 comments
Closed
4 tasks done

[feature request] support yurt-manager work in specified namespace #1361

y-ykcir opened this issue Apr 10, 2023 · 9 comments
Labels
kind/feature kind/feature

Comments

@y-ykcir
Copy link
Member

y-ykcir commented Apr 10, 2023

What would you like to be added:
All controllers and webhooks in yurt-manager can be deployed in specified namespace.

Why is this needed:
improve the deployment flexibility of OpenYurt components.

others
/kind feature

The current yurt-manager needs to be adapted to the specified namespace by modifying the following:

  • Pool-coordinator cert controller
  • Gateway controller in raven
  • Yurt-manager webhooks
  • Other components not yet migrated...
@y-ykcir y-ykcir added the kind/feature kind/feature label Apr 10, 2023
@rambohe-ch
Copy link
Member

@y-ykcir would you be able to take this work?

@y-ykcir
Copy link
Member Author

y-ykcir commented Apr 12, 2023

OK, I'd like to.

@rambohe-ch
Copy link
Member

@y-ykcir yurt-manager component has been updated recently, would you be able to check all yurt-manager again whether can work in specified namespace or not?

@y-ykcir
Copy link
Member Author

y-ykcir commented Apr 20, 2023

@y-ykcir yurt-manager component has been updated recently, would you be able to check all yurt-manager again whether can work in specified namespace or not?

Sure

@y-ykcir
Copy link
Member Author

y-ykcir commented Apr 21, 2023

@rambohe-ch It seems that the newly migrated controllers do not need to be modified to be compatible with the specified namespace, maybe we can close this issue?

@rambohe-ch
Copy link
Member

@rambohe-ch It seems that the newly migrated controllers do not need to be modified to be compatible with the specified namespace, maybe we can close this issue?

@y-ykcir would you like to take a test for OpenYurt in specified namespace, and make sure OpenYurt can work in specified namespace?

@y-ykcir
Copy link
Member Author

y-ykcir commented Apr 21, 2023

@rambohe-ch It seems that the newly migrated controllers do not need to be modified to be compatible with the specified namespace, maybe we can close this issue?

@y-ykcir would you like to take a test for OpenYurt in specified namespace, and make sure OpenYurt can work in specified namespace?

@rambohe-ch Is it possible to test this thing with Kind on the m1 Mac? Sorry that I currently do not have an available Linux server, it may not be convenient for testing.

@rambohe-ch
Copy link
Member

@rambohe-ch It seems that the newly migrated controllers do not need to be modified to be compatible with the specified namespace, maybe we can close this issue?

@y-ykcir would you like to take a test for OpenYurt in specified namespace, and make sure OpenYurt can work in specified namespace?

@rambohe-ch Is it possible to test this thing with Kind on the m1 Mac? Sorry that I currently do not have an available Linux server, it may not be convenient for testing.

@y-ykcir i think we can not check this feature on Kind, because Kind has not used yurtadm join command to add nodes.

@rambohe-ch
Copy link
Member

@y-ykcir all the work of this issue had been done, so i will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants