Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make servicetopology filter in yurthub work properly when service or nodepool change #1019

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

LinFCai
Copy link
Contributor

@LinFCai LinFCai commented Sep 27, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

make servicetopology filter in yurthub work properly when service or nodepool change

Which issue(s) this PR fixes:

Fixes #871

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

 "NONE"

@openyurt-bot
Copy link
Collaborator

@LinFCai: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

make servicetopology filter in yurthub work properly when service or nodepool change

Which issue(s) this PR fixes:

Fixes #871

Special notes for your reviewer:

@rambohe-ch

Does this PR introduce a user-facing change?

"NONE"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/XL size/XL: 500-999 label Sep 27, 2022
@LinFCai LinFCai force-pushed the servicetopology branch 2 times, most recently from 464fe2a to 25fbfd3 Compare September 27, 2022 07:26
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1019 (44ab6d0) into master (98a21c7) will increase coverage by 0.13%.
The diff coverage is 48.89%.

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
+ Coverage   47.60%   47.74%   +0.13%     
==========================================
  Files          89       95       +6     
  Lines       12548    13013     +465     
==========================================
+ Hits         5974     6213     +239     
- Misses       6059     6266     +207     
- Partials      515      534      +19     
Flag Coverage Δ
unittests 47.74% <48.89%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/servicetopology/servicetopology.go 21.89% <21.89%> (ø)
pkg/controller/servicetopology/adapter/adapter.go 78.94% <78.94%> (ø)
...servicetopology/adapter/endpointslicev1_adapter.go 81.81% <81.81%> (ø)
...cetopology/adapter/endpointslicev1beta1_adapter.go 82.22% <82.22%> (ø)
...oller/servicetopology/adapter/endpoints_adapter.go 88.23% <88.23%> (ø)
pkg/yurthub/server/server.go 0.00% <0.00%> (ø)
pkg/yurthub/otaupdate/ota.go 57.84% <0.00%> (ø)
.../daemonpodupdater/daemon_pod_updater_controller.go 39.39% <0.00%> (+1.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LinFCai LinFCai force-pushed the servicetopology branch 5 times, most recently from a1c2f90 to 57cd35e Compare September 27, 2022 09:30
@rambohe-ch
Copy link
Member

@LinFCai Thank you for posting pull request for service topology controller. How about add unit tests for the added code?

@openyurt-bot openyurt-bot added the approved approved label Oct 9, 2022
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinFCai, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit cd00f26 into openyurtio:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]when nodepool or service change, service topology function can work
3 participants