-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make servicetopology filter in yurthub work properly when service or nodepool change #1019
Conversation
@LinFCai: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
464fe2a
to
25fbfd3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
==========================================
+ Coverage 47.60% 47.74% +0.13%
==========================================
Files 89 95 +6
Lines 12548 13013 +465
==========================================
+ Hits 5974 6213 +239
- Misses 6059 6266 +207
- Partials 515 534 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
a1c2f90
to
57cd35e
Compare
@LinFCai Thank you for posting pull request for service topology controller. How about add unit tests for the added code? |
57cd35e
to
823b90e
Compare
823b90e
to
53ec02f
Compare
53ec02f
to
44ab6d0
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LinFCai, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
make servicetopology filter in yurthub work properly when service or nodepool change
Which issue(s) this PR fixes:
Fixes #871
Special notes for your reviewer:
/assign @rambohe-ch
Does this PR introduce a user-facing change?