Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]when nodepool or service change, service topology function can work #871

Closed
rambohe-ch opened this issue Jun 6, 2022 · 7 comments · Fixed by #1006 or #1019
Closed
Assignees
Labels
kind/feature kind/feature

Comments

@rambohe-ch
Copy link
Member

What would you like to be added:
For servicetopology filter in Yurthub, beside endpointSlice resource, nodePool and service change can be handled.
maybe endpoints filter also should be enhanced.

Why is this needed:
servicetopology filter in Yurthub can work properly when endpointSlices resource change. if nodePool or service resource change, like updating topology annotation for service or removing node from nodePool, endpointslices on the edge nodes will not be updated.

others
/kind feature

@LinFCai
Copy link
Contributor

LinFCai commented Aug 25, 2022

@rambohe-ch. Hello, I will take over this work.

@rambohe-ch
Copy link
Member Author

@rambohe-ch. Hello, I will take over this work.

@LinFCai Thank you for taking over this work. /assign @LinFCai

@rambohe-ch
Copy link
Member Author

@LinFCai please post a proposal about this feature before making code pull request. and how to make the proposal, you can reference this example: https://github.com/openyurtio/openyurt/blob/master/docs/proposals/20210720-data-filtering-framework.md

@LinFCai
Copy link
Contributor

LinFCai commented Aug 26, 2022

ok

@rambohe-ch
Copy link
Member Author

@LinFCai Hi, Do you have any progress for this issue?

@LinFCai
Copy link
Contributor

LinFCai commented Sep 15, 2022

@rambohe-ch I have posted the proposal here #1006.

@rambohe-ch
Copy link
Member Author

/reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
No open projects
Status: Done
2 participants