Add spec for ConvolutionOp #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdasgup3
commented
Nov 4, 2022
sdasgup3
commented
Nov 4, 2022
sdasgup3
commented
Nov 4, 2022
sdasgup3
commented
Nov 4, 2022
sdasgup3
force-pushed
the
spec-conv
branch
2 times, most recently
from
8bcf997
to
d1cfa4e
Compare
This was referenced Nov 5, 2022
ghpvnist
requested changes
Nov 8, 2022
ghpvnist
requested changes
Nov 8, 2022
burmako
suggested changes
Dec 7, 2022
burmako
reviewed
Dec 10, 2022
burmako
suggested changes
Dec 13, 2022
…newly added check for window reversal
burmako
approved these changes
Dec 13, 2022
ghpvnist
approved these changes
Dec 13, 2022
Merged
burmako
pushed a commit
that referenced
this pull request
Jan 9, 2023
As per #441 (comment), the spec should be a `revisit` for #730 which is now fixed.
GleasonK
pushed a commit
to GleasonK/stablehlo
that referenced
this pull request
Jan 19, 2023
As per openxla#441 (comment), the spec should be a `revisit` for openxla#730 which is now fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #359
The PR addresses the followings:
precision_config: The precision_config parameter is a array of enums without any constraint on its size. Need to resolve this.window_reversalin ConvolutionOp #399Only missing peice:
The constraint between output feature size and input batch size. Working on getting a better understanding on this: Done
Type inference should be "revisit" as well because of #600.