Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for ConvolutionOp #359

Closed
sdasgup3 opened this issue Oct 18, 2022 · 0 comments · Fixed by #441
Closed

Add spec for ConvolutionOp #359

sdasgup3 opened this issue Oct 18, 2022 · 0 comments · Fixed by #441
Assignees
@sdasgup3
Labels
Spec

Comments

@sdasgup3
Copy link
Member

Request description

To spec stablehlo.convolution.
@sdasgup3 sdasgup3 added the Spec label Oct 18, 2022
@sdasgup3 sdasgup3 self-assigned this Oct 18, 2022
@sdasgup3 sdasgup3 mentioned this issue Nov 4, 2022
Merged
sdasgup3 added a commit that referenced this issue Dec 13, 2022
@sdasgup3
Add spec for ConvolutionOp (#441)
66d8481 
fixes #359 

The PR addresses the followings:
1. Spec of ConvolutionOp
2. Clarify the semantics of `precision_config` : The precision_config
parameter is a array of enums without any constraint on its size. Need
to resolve this.
- update: Added constraints on the parameter. With that the verifier is
in sync with this spec. Also added
#445 for further exploration.
4. Fix
#360 (comment)
5. Avoid disabling clang formatting in StablehloOps.cpp.
6. Address #399

Only missing peice:

The constraint between output feature size and input batch size. Working
on getting a better understanding on this: Done

Type inference should be "revisit" as well because of #600.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdasgup3 sdasgup3

Labels
Spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add spec for ConvolutionOp sdasgup3/stablehlo
1 participant
@sdasgup3