Expose channel_id in CollectivePermuteOp #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmako
suggested changes
Oct 25, 2022
subhankarshah
force-pushed
the
CollectivePermuteChannelId
branch
from
2572056 to
f34fa56
Compare
GleasonK
reviewed
Oct 27, 2022
burmako
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Similarly to #272, my recommendation is to approve this change, with the same reasoning: this is a non-controversial backward-compatible change, and accepting it doesn't violate any of the existing commitments (it sticks to existing HLO semantics, and it is compatible with the extent of the current compatibility commitments).
GleasonK
pushed a commit
to GleasonK/stablehlo
that referenced
this pull request
Nov 10, 2022
burmako
added
Migrate from MHLO
burmako
pushed a commit
that referenced
this pull request
Dec 20, 2022
Rationale for approval is the same as in #272, #388, #403 and #673: this is a non-controversial backward-compatible change, and accepting it doesn't violate any of the existing commitments (it sticks to existing HLO semantics, and it is compatible with the extent of the current compatibility commitments). MLIR-HLO commit: tensorflow/mlir-hlo@bd07cb9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #340