Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input output aliasing to CustomCallOp #403

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Add input output aliasing to CustomCallOp #403

merged 6 commits into from
Nov 9, 2022

Conversation

subhankarshah
Copy link
Member

Closes #235

@subhankarshah subhankarshah added Spec Migrate to MHLO PR that needs to be migrated to MLIR-HLO labels Oct 29, 2022
@subhankarshah subhankarshah requested a review from burmako October 29, 2022 00:03
@subhankarshah subhankarshah self-assigned this Oct 29, 2022
@subhankarshah subhankarshah force-pushed the OutputAliasing branch 2 times, most recently from ae58c7c to 85210b9 Compare October 29, 2022 00:14
@burmako burmako added RFC and removed Spec labels Oct 30, 2022
@burmako burmako assigned burmako and unassigned subhankarshah Nov 1, 2022
burmako
burmako suggested changes Nov 8, 2022
View reviewed changes
stablehlo/dialect/StablehloAttrs.td Outdated Show resolved Hide resolved
stablehlo/dialect/StablehloOps.td Outdated Show resolved Hide resolved
stablehlo/integrations/c/StablehloAttributes.h Show resolved Hide resolved
stablehlo/integrations/c/StablehloAttributes.cpp Outdated Show resolved Hide resolved
stablehlo/integrations/python/tests/stablehlo.py Outdated Show resolved Hide resolved
stablehlo/integrations/python/tests/stablehlo.py Outdated Show resolved Hide resolved
stablehlo/integrations/python/tests/stablehlo.py Outdated Show resolved Hide resolved
stablehlo/tests/ops_stablehlo.mlir Outdated Show resolved Hide resolved
@burmako burmako assigned subhankarshah and unassigned burmako Nov 8, 2022
@subhankarshah subhankarshah requested a review from burmako November 8, 2022 08:32
@GleasonK GleasonK mentioned this pull request Nov 8, 2022
Closed
burmako
burmako suggested changes Nov 8, 2022
View reviewed changes
stablehlo/integrations/python/tests/stablehlo.py Outdated Show resolved Hide resolved
stablehlo/dialect/StablehloOps.td Outdated Show resolved Hide resolved
@burmako
Copy link
Contributor

burmako commented Nov 8, 2022

Rationale for approval is the same as in #272 and #388: this is a non-controversial backward-compatible change, and accepting it doesn't violate any of the existing commitments (it sticks to existing HLO semantics, and it is compatible with the extent of the current compatibility commitments).

@burmako burmako merged commit 5d6a76e into openxla:main Nov 9, 2022
@burmako burmako added Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit and removed Migrate to MHLO PR that needs to be migrated to MLIR-HLO labels Nov 13, 2022
@burmako burmako mentioned this pull request Dec 20, 2022
Merged
burmako pushed a commit that referenced this pull request Dec 20, 2022
Add channel_id to AllToAllOp (#794)
93e7cf8 
Rationale for approval is the same as in #272, #388, #403 and #673: this
is a non-controversial backward-compatible change, and accepting it
doesn't violate any of the existing commitments (it sticks to existing
HLO semantics, and it is compatible with the extent of the current
compatibility commitments).

MLIR-HLO commit: tensorflow/mlir-hlo@bd07cb9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burmako burmako burmako approved these changes

@GleasonK GleasonK Awaiting requested review from GleasonK

Assignees

@burmako burmako

Labels
Migrate from MHLO Issue or PR that migrates from an MLIR-HLO commit RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding input output aliasing to CustomCallOp
3 participants
@subhankarshah @burmako @GleasonK