Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifischedule: respect global enable during startup #22989

Closed

Conversation

raenye
Copy link
Contributor

@raenye raenye commented Dec 25, 2023

(combined into #22974)

Fixes: e0d7181
Closes: openwrt#22988

Make `startup()` check whether `wifi_schedule` is globally enabled,
and if it is disabled, do not modify `/etc/config/wireless`.

Signed-off-by: Rani Hod <[email protected]>
@raenye raenye changed the title wifi_schedule: respect global enable during startup wifischedule: respect global enable during startup Dec 25, 2023
@BKPepe
Copy link
Member

BKPepe commented Dec 26, 2023

You need to bump PKG_RELEASE in the Makefile.

@raenye
Copy link
Contributor Author

raenye commented Dec 26, 2023

Thanks @BKPepe, I'm just not sure how to deal with two concurrent PRs to the same package (the other is #22974).

Maybe I should submit a single PR for both changes? (fix the two related bugs together)

@1715173329
Copy link
Member

Thanks @BKPepe, I'm just not sure how to deal with two concurrent PRs to the same package (the other is #22974).

Maybe I should submit a single PR for both changes? (fix the two related bugs together)

Yes, to the same package, it's okay.

@raenye
Copy link
Contributor Author

raenye commented Dec 26, 2023

Done; please see #22974.

@raenye raenye closed this Dec 26, 2023
@raenye raenye deleted the wifischedule-respect-global-enable branch December 29, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants