wifischedule: startup script ignores global enabled config option #22988
Comments
raenye
added a commit
to raenye/packages
that referenced
this issue
Dec 24, 2023
Fixes: e0d7181 Closes: openwrt#22988 Make `startup()` check whether `wifi_schedule` is globally enabled, and if it is disabled, do not modify `/etc/config/wireless`. Signed-off-by: Rani Hod <[email protected]>
raenye
added a commit
to raenye/packages
that referenced
this issue
Dec 26, 2023
Fixes: e0d7181 Closes: openwrt#22973 Closes: openwrt#22988 1. Make the new `startup()` function in `/usr/bin/wifi_schedule.sh` respect the global `enabled` config flag; in particular, make no changes to `/etc/config/wireless` when wifi_schedule is disabled. 2. Make the new `/etc/init.d/wifi_schedule` service script executable. Signed-off-by: Rani Hod <[email protected]>
raenye
added a commit
to raenye/packages
that referenced
this issue
Jan 3, 2024
Fixes: e0d7181 Closes: openwrt#22973 Closes: openwrt#22988 1. Make the new `startup()` function in `/usr/bin/wifi_schedule.sh` respect the global `enabled` config flag; in particular, make no changes to `/etc/config/wireless` when wifi_schedule is disabled. 2. Make the new `/etc/init.d/wifi_schedule` service script executable. Signed-off-by: Rani Hod <[email protected]>
neheb
pushed a commit
that referenced
this issue
Jan 3, 2024
Fixes: e0d7181 Closes: #22973 Closes: #22988 1. Make the new `startup()` function in `/usr/bin/wifi_schedule.sh` respect the global `enabled` config flag; in particular, make no changes to `/etc/config/wireless` when wifi_schedule is disabled. 2. Make the new `/etc/init.d/wifi_schedule` service script executable. Signed-off-by: Rani Hod <[email protected]>
NoctivagusObitus
pushed a commit
to NoctivagusObitus/packages
that referenced
this issue
Feb 22, 2024
Fixes: e0d7181 Closes: openwrt#22973 Closes: openwrt#22988 1. Make the new `startup()` function in `/usr/bin/wifi_schedule.sh` respect the global `enabled` config flag; in particular, make no changes to `/etc/config/wireless` when wifi_schedule is disabled. 2. Make the new `/etc/init.d/wifi_schedule` service script executable. Signed-off-by: Rani Hod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Maintainer: @newkit
Environment: all
Description:
In e0d7181 the function
startup()was added to/usr/bin/wifi_schedule.sh. It runs once via/etc/init.d/wifi_scheduleand also via cron.This function disables all or enables all wifi-ifaces in
/etc/config/wireless(via uci), and does it even whenenabled=0is present in/etc/config/wifi_schedule.Luckily, this bug does not manifest due to #22973, which prevents the init script from running altogether (the cron jobs are cancelled with
enabled=0so they're not the problem).The text was updated successfully, but these errors were encountered: