Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy ssd-like IRs support #1970

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Apr 4, 2023

Summary

In old SSD-like IRs bbox and label layers have different shapes than in current implementation. Wrapper was fixes to support both IR formats.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sovrasov sovrasov requested a review from a team as a code owner April 4, 2023 14:15
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 4, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the fix. We need to be careful for this kind of change in the future. By the way, could you update the change log? It's a new convention and I think this change is worth to note. :)

@github-actions github-actions bot added the DOC Improvements or additions to documentation label Apr 4, 2023
@sovrasov sovrasov added this to the 1.2.0 milestone Apr 4, 2023
@goodsong81 goodsong81 added the FIX defect fix label Apr 5, 2023
@goodsong81 goodsong81 changed the title [FIX] Add legacy ssd-like IRs support Add legacy ssd-like IRs support Apr 5, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for old version of openvino model inference? It would be nice if you add some summary and motivation of this work.

@sovrasov
Copy link
Contributor Author

sovrasov commented Apr 5, 2023

Is this for old version of openvino model inference? It would be nice if you add some summary and motivation of this work.

Added a brief description in summary

@sovrasov sovrasov merged commit 9410c0d into openvinotoolkit:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation FIX defect fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants