Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCE] Parametrize saliency maps dumping in export (part 2) #1888

Merged
merged 11 commits into from
Mar 17, 2023

Conversation

GalyaZalesskaya
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya commented Mar 14, 2023

Summary

This PR is the 2nd part of parameterizing feature maps and vector dumping in export using dump_features.
The 1st part with its implementation for detection and classification task is here (#1708).

  • Segmentation: added feature vector export according to dump_features
  • Action: added NotImplementationError, if feature dumping was called
  • Anomaly: added NotImplementationError, if feature dumping was called
  • Tests: added tests for classification, detection, and segmentation with export with features. Updated explain tests to use IR with exported features.
  • Documentation: updates CLI documentation accordingly

Related ticket: 101710

TODO:

  • Documentation revisit for explain feature: explanation and tutorial

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Mar 14, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Mar 15, 2023
@GalyaZalesskaya GalyaZalesskaya marked this pull request as ready for review March 15, 2023 10:13
@GalyaZalesskaya GalyaZalesskaya requested a review from a team as a code owner March 15, 2023 10:13
@GalyaZalesskaya GalyaZalesskaya added ENHANCE Enhancement of existing features CLI Any changes in OTE CLI labels Mar 15, 2023
@github-actions github-actions bot added API Any changes in OTX API and removed CLI Any changes in OTE CLI labels Mar 15, 2023
@yunchu
Copy link
Contributor

yunchu commented Mar 16, 2023

@GalyaZalesskaya could you set the milestone for this PR?

Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good to me, thanks!
Could you resolve the test failures?

@GalyaZalesskaya GalyaZalesskaya added this to the 1.1.0 milestone Mar 16, 2023
@GalyaZalesskaya
Copy link
Contributor Author

@yunchu thank you, I added 1.1.0 milestone
@goodsong81 thank you, yes, I'm working on it

@GalyaZalesskaya
Copy link
Contributor Author

@sovrasov @goodsong81 @negvet Tests passed, can you please review these changes again?

@goodsong81 goodsong81 merged commit 8f2c882 into openvinotoolkit:develop Mar 17, 2023
@GalyaZalesskaya GalyaZalesskaya deleted the gz/dump_feature2 branch March 17, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API DOC Improvements or additions to documentation ENHANCE Enhancement of existing features TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants