-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCE] Parametrize saliency maps dumping in export parametrizable #1708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment from my side
Unit tests are required, although can be added in a separate PR |
Could you also check pre-commit issues? |
@JihwanEom @sovrasov Your comments were reflected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please check pre-commits
Codecov ReportBase: 77.80% // Head: 77.76% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1708 +/- ##
===========================================
- Coverage 77.80% 77.76% -0.05%
===========================================
Files 469 469
Lines 32800 32829 +29
===========================================
+ Hits 25521 25528 +7
- Misses 7279 7301 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@JihwanEom @sovrasov @negvet Tests were fixed, can you review again please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@GalyaZalesskaya I have a suspicion that instance-segmentation export is not working since this PR was merged.
i got runtime error |
Added
dump_features
parameter inotx export
not to calculate and dump saliency maps and representation vectors for each export.Checked export and inference of pth and IR model for:
Expected result: improved efficiency of deployed models if no explanation is needed
TODO