Move pass pattern to ov #7255
Merged
Move pass pattern to ov #7255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyachur
force-pushed
the
move_pass_pattern_to_ov
branch
from
63daf37 to
755212d
Compare
ilyachur
force-pushed
the
move_pass_pattern_to_ov
branch
from
494091e to
70ecf71
Compare
ilyachur
requested review from
mitruska,
mbencer,
tomdol,
tsocha,
ilya-lavrenov and
apankratovantonp
| } | ||
|
|
||
| OPENVINO_DEPRECATED("Use MatcherPass instead") | ||
| void add_matcher(const std::shared_ptr<pattern::Matcher>& m, |
There was a problem hiding this comment.
can we remove it finally?
There was a problem hiding this comment.
It can be backward incompatible for our old users.
There was a problem hiding this comment.
why? it's deprecated for several releases
There was a problem hiding this comment.
Hmm, yes, it is a valid comment. So I propose to remove these deprecated methods in the separate PR.
There was a problem hiding this comment.
It is still used by some OV components actually
ilya-lavrenov
approved these changes
Sep 1, 2021
| using ov::pass::BackwardGraphRewrite; | ||
| using ov::pass::GraphRewrite; | ||
| using ov::pass::MatcherPass; | ||
| using ov::pass::RecurrentGraphRewrite; |
There was a problem hiding this comment.
Let's keep it only in legacy API.
| namespace pass { | ||
| enum class PassProperty : uint32_t { |
There was a problem hiding this comment.
Let's keep pass property in legacy API
Comment on lines
+32
to
+33
| using ov::pass::PassProperty; | ||
| using ov::pass::PassPropertyMask; |
| }; | ||
| using ov::pass::pattern::Matcher; | ||
| using ov::pass::pattern::MatcherState; | ||
| using ov::pass::pattern::RecurrentMatcher; |
There was a problem hiding this comment.
Let's keep it in legacy API
Comment on lines
+98
to
+108
| enum class FusionType : uint32_t { | ||
| //`DIFFERENTIABLE_FUSIONS` produce ops that support autodiff | ||
| // i.e. implement `generate_adjoints` | ||
| DIFFERENTIABLE_FUSIONS = 0x1, | ||
| REGULAR_FUSIONS = 0x2, | ||
| //`FOP_FUSIONS` produce ops in the FusedOps category that might | ||
| // not be supported by all backends | ||
| FOP_FUSIONS = 0x4, | ||
| ALL_FUSIONS = 0xFFFFFFFF | ||
| }; | ||
| using FusionTypeMask = ngraph::EnumMask<FusionType>; |
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
* Moved ngraph::Node to ov namespace * Fixed code style * Fixed VPU * Fixed GNA * Fixed tests * Added aliases for backward compatibility * Fix clDNN * Try to fix build * Fixed comment * Renamed RTTI macros * Add new headers * Fixed ngraph build * Fixed unit tests * Try to fix Serialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR depends on #7240