Moved ngraph::Node to ov namespace #7240
Conversation
ilyachur
requested review from
mbencer,
GlebKazantaev,
mitruska,
tomdol,
tsocha,
jane-intel,
ggalieroc-zz and
a team
| /// TODO: Make a plan to deprecate this. | ||
| Output(const std::shared_ptr<Node>& node, size_t index); |
There was a problem hiding this comment.
I understand this and other TODO comments are copied from the original file, but maybe we have a good moment to review and update such info to have a clear situation about deprecation plans.
I don't mean it's needed in this PR but still related.
There was a problem hiding this comment.
I will do it in the separate PR. it affects a lot of places
There was a problem hiding this comment.
I don't see any reason to remove this c-tor as in most cases we are working with std::shared_ptr<Node> but not with Node * so it is more convenient and doesn't have any side-effects.
There was a problem hiding this comment.
As I already said, I tried to deprecate this constructor, but it affects several places. I don't want to mix these changes in this PR.
...engine/src/transformations/src/transformations/common_optimizations/strides_optimization.cpp
Outdated
Show resolved
Hide resolved
| /// TODO: Make a plan to deprecate this. | ||
| Output(const std::shared_ptr<Node>& node, size_t index); |
There was a problem hiding this comment.
I don't see any reason to remove this c-tor as in most cases we are working with std::shared_ptr<Node> but not with Node * so it is more convenient and doesn't have any side-effects.
* Moved ngraph::Node to ov namespace * Fixed code style * Fixed VPU * Fixed GNA * Fixed tests * Added aliases for backward compatibility * Fix clDNN * Try to fix build * Fixed comment * Renamed RTTI macros
No description provided.