Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise less equal #6720

Merged
merged 14 commits into from
Aug 4, 2021
Merged

Revise less equal #6720

merged 14 commits into from
Aug 4, 2021

Conversation

bszmelcz
Copy link
Contributor

@bszmelcz bszmelcz commented Jul 20, 2021 •
edited
Loading

Details:

  • update spec
  • add backend test
  • serialize SLT is added as a part of the PR
  • visitors test is added as a part of the PR

Tickets:

  • 37446

@bszmelcz bszmelcz added the category: Core OpenVINO Core (aka ngraph) label Jul 21, 2021
@bszmelcz bszmelcz marked this pull request as ready for review July 23, 2021 10:57
@bszmelcz bszmelcz requested a review from a team as a code owner July 23, 2021 10:57
@bszmelcz bszmelcz requested review from a team, sdurawa and ilyachur July 23, 2021 10:57
sdurawa
sdurawa reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@sdurawa sdurawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove LessEqual tests from backend tests.

docs/ops/comparison/LessEqual_1.md Outdated Show resolved Hide resolved
docs/template_plugin/tests/functional/op_reference/less_eq.cpp Outdated Show resolved Hide resolved
@bszmelcz bszmelcz requested review from a team and sdurawa July 26, 2021 10:12
ilyachur
ilyachur reviewed Jul 27, 2021
View reviewed changes
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the same activity in the PR: #6728

@bszmelcz bszmelcz requested a review from ilyachur July 29, 2021 21:03
lazarevevgeny
lazarevevgeny reviewed Aug 2, 2021
View reviewed changes
docs/ops/comparison/LessEqual_1.md Outdated
@@ -4,48 +4,50 @@

**Category**: Comparison binary operation

**Short description**: *LessEqual* performs element-wise comparison operation with two given tensors applying multi-directional broadcast rules.
**Short description**: *LessEqual* performs element-wise comparison operation with two given tensors applying multi-directional broadcast rules specified in the *auto_broadcast* attribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove word "multi-directional"

lazarevevgeny
lazarevevgeny approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@lazarevevgeny lazarevevgeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment for the spec.

@ilyachur ilyachur added this to the 2022.1 milestone Aug 3, 2021
@ilyachur
Copy link
Contributor

ilyachur commented Aug 3, 2021

Please fix CI

@ilyachur ilyachur enabled auto-merge (squash) August 3, 2021 06:25
@ilyachur ilyachur merged commit c963136 into openvinotoolkit:master Aug 4, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@bszmelcz
Revise less equal (openvinotoolkit#6720)
fc20046 
* update spec, add visitors, backend test

* remove visitors test as it is implemented in another PR

* remove visitors test from CMakeLists

* remove old backend tests, refactor minor parts of the code

* add namespace

* refaactor template test for less_equal op
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@bszmelcz @andrei-cv
Revise less equal (openvinotoolkit#6720)
f3a34c7 
* update spec, add visitors, backend test

* remove visitors test as it is implemented in another PR

* remove visitors test from CMakeLists

* remove old backend tests, refactor minor parts of the code

* add namespace

* refaactor template test for less_equal op
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@bszmelcz @akuporos
Revise less equal (openvinotoolkit#6720)
3dd0be3 
* update spec, add visitors, backend test

* remove visitors test as it is implemented in another PR

* remove visitors test from CMakeLists

* remove old backend tests, refactor minor parts of the code

* add namespace

* refaactor template test for less_equal op
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazarevevgeny lazarevevgeny lazarevevgeny approved these changes

@ilyachur ilyachur ilyachur approved these changes

@sdurawa sdurawa Awaiting requested review from sdurawa

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bszmelcz @ilyachur @lazarevevgeny @sdurawa