Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Less #6728

Merged
merged 14 commits into from
Jul 28, 2021
Merged

Revise Less #6728

merged 14 commits into from
Jul 28, 2021

Conversation

blesniewski
Copy link
Contributor

@blesniewski blesniewski commented Jul 21, 2021

Details:

Tickets:

  • 37445

@blesniewski
Copy link
Contributor Author

@ilyachur I'd like to know your opinion on this approach to Comparison OP backend tests.

@blesniewski blesniewski requested a review from pelszkow July 21, 2021 10:50
Copy link
Contributor

@pelszkow pelszkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blesniewski blesniewski self-assigned this Jul 22, 2021
@blesniewski blesniewski added the category: Core OpenVINO Core (aka ngraph) label Jul 22, 2021
@blesniewski blesniewski marked this pull request as ready for review July 22, 2021 11:37
@blesniewski blesniewski requested a review from a team as a code owner July 22, 2021 11:37
@blesniewski blesniewski requested a review from a team July 22, 2021 11:37
@blesniewski blesniewski requested a review from ilyachur July 27, 2021 07:02
@blesniewski blesniewski requested a review from a team July 28, 2021 07:16
@ilyachur ilyachur merged commit 1471095 into openvinotoolkit:master Jul 28, 2021
@blesniewski blesniewski added this to the 2022.1 milestone Jul 29, 2021
@mitruska mitruska mentioned this pull request Aug 9, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* Revise spec

* Comparison backend test POC

* Split Comparison ops tests into separate files

* remove comparison.cpp, remove unused imports, replace for_each with range based for

* remove unnecessary ngraph:: prefixes

* Fix links in spec

* Add Less to trusted ops list

* Add missing ','

* Use builder in backend tests

* Remove old backend tests for less, equal
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
* Revise spec

* Comparison backend test POC

* Split Comparison ops tests into separate files

* remove comparison.cpp, remove unused imports, replace for_each with range based for

* remove unnecessary ngraph:: prefixes

* Fix links in spec

* Add Less to trusted ops list

* Add missing ','

* Use builder in backend tests

* Remove old backend tests for less, equal
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* Revise spec

* Comparison backend test POC

* Split Comparison ops tests into separate files

* remove comparison.cpp, remove unused imports, replace for_each with range based for

* remove unnecessary ngraph:: prefixes

* Fix links in spec

* Add Less to trusted ops list

* Add missing ','

* Use builder in backend tests

* Remove old backend tests for less, equal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants