-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise Less #6728
Merged
Merged
Revise Less #6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ilyachur I'd like to know your opinion on this approach to Comparison OP backend tests. |
ilyachur
reviewed
Jul 21, 2021
docs/template_plugin/tests/functional/op_reference/comparison.cpp
Outdated
Show resolved
Hide resolved
pelszkow
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/template_plugin/tests/functional/op_reference/comparison.hpp
Outdated
Show resolved
Hide resolved
ilyachur
reviewed
Jul 23, 2021
ilyachur
reviewed
Jul 27, 2021
ilyachur
approved these changes
Jul 28, 2021
Merged
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
* Revise spec * Comparison backend test POC * Split Comparison ops tests into separate files * remove comparison.cpp, remove unused imports, replace for_each with range based for * remove unnecessary ngraph:: prefixes * Fix links in spec * Add Less to trusted ops list * Add missing ',' * Use builder in backend tests * Remove old backend tests for less, equal
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Aug 30, 2021
* Revise spec * Comparison backend test POC * Split Comparison ops tests into separate files * remove comparison.cpp, remove unused imports, replace for_each with range based for * remove unnecessary ngraph:: prefixes * Fix links in spec * Add Less to trusted ops list * Add missing ',' * Use builder in backend tests * Remove old backend tests for less, equal
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
* Revise spec * Comparison backend test POC * Split Comparison ops tests into separate files * remove comparison.cpp, remove unused imports, replace for_each with range based for * remove unnecessary ngraph:: prefixes * Fix links in spec * Add Less to trusted ops list * Add missing ',' * Use builder in backend tests * Remove old backend tests for less, equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: