Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] prohibit fusing if dropped node contain > 1 child edges #6705

Merged
merged 2 commits into from
Jul 30, 2021
Merged

[CPU] prohibit fusing if dropped node contain > 1 child edges #6705

merged 2 commits into from
Jul 30, 2021

Conversation

mandrono
Copy link

Tickets:

  • 59847

@mandrono mandrono requested review from a team July 19, 2021 17:10
@mandrono mandrono marked this pull request as draft July 19, 2021 17:11
@openvino-pushbot openvino-pushbot added the category: CPU OpenVINO CPU plugin label Jul 19, 2021
@mandrono mandrono force-pushed the fix/59847 branch 2 times, most recently from d877c3f to 35e7157 Compare July 21, 2021 15:51
dmitry-gorokhov
dmitry-gorokhov reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic itself LGTM. Could you please add subgraph test which reproduces the issue?

@dmitry-gorokhov dmitry-gorokhov added this to the 2022.1 milestone Jul 26, 2021
@dmitry-gorokhov dmitry-gorokhov self-assigned this Jul 26, 2021
@mandrono mandrono force-pushed the fix/59847 branch 2 times, most recently from f53d77b to 2131c52 Compare July 28, 2021 06:59
@mandrono mandrono marked this pull request as ready for review July 28, 2021 07:00
@mandrono mandrono requested a review from a team July 28, 2021 07:00
@mandrono
Copy link
Author

mandrono commented Jul 28, 2021 •
edited
Loading

The logic itself LGTM. Could you please add subgraph test which reproduces the issue?

subgraph test was added

@dmitry-gorokhov dmitry-gorokhov merged commit 2b871eb into openvinotoolkit:master Jul 30, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
[CPU] prohibit fusing if dropped node contain > 1 child edges (openvi…
0114fc9 
…notoolkit#6705)
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@andrei-cv
[CPU] prohibit fusing if dropped node contain > 1 child edges (openvi…
5138cff 
…notoolkit#6705)
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@akuporos
[CPU] prohibit fusing if dropped node contain > 1 child edges (openvi…
01bbf14 
…notoolkit#6705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mandrono @dmitry-gorokhov @openvino-pushbot