Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrontEnd]enable pdpd ops conversion part3 #6636

Merged
merged 17 commits into from
Aug 4, 2021
Merged

[FrontEnd]enable pdpd ops conversion part3 #6636

merged 17 commits into from
Aug 4, 2021

Conversation

zhangYiIntel
Copy link
Contributor

Details:

Tickets:

  • 53423

@zhangYiIntel zhangYiIntel requested review from a team, ilyachur, nosovmik, jane-intel and mvafin July 14, 2021 05:12
@zhangYiIntel zhangYiIntel added this to the 2022.1 milestone Jul 14, 2021
@zhangYiIntel zhangYiIntel added the category: Core OpenVINO Core (aka ngraph) label Jul 14, 2021
@ilyachur
Copy link
Contributor

@jane-intel @mvafin Could you have a look?

@nosovmik nosovmik requested a review from GlebKazantaev July 23, 2021 11:31
@nosovmik
Copy link
Contributor

I don't see tests for these ops for this PR. Are they going to be merged?

@zhangYiIntel
Copy link
Contributor Author

@nosovmik Yes we will add tests for these Ops. Previously, about the OpFuzzyTest, ilya has different opinion about how to test the conversion. So we don't enable it in this PR. But Since we have alignment with the test method. We will add them back later in another PR

@ilya-lavrenov
Copy link
Contributor

Approved with the same comment as here #6632 (comment)

jane-intel
jane-intel requested changes Jul 26, 2021
View reviewed changes
ngraph/frontend/paddlepaddle/src/op/mul.cpp Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/pow.cpp Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/range.cpp Outdated Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/reshape2.cpp Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/shape.cpp Outdated Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/softmax.cpp Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/squeeze.cpp Outdated Show resolved Hide resolved
luo-cheng2021 and others added 4 commits July 27, 2021 10:29
@luo-cheng2021
deal empty axis (#5)
cd1bfc0 
* deal empty axis

* apply review comments
@luo-cheng2021
fix code style
bdb3f4f 
* fix code style
@zhangYiIntel
change shape to i32
ce5c1ea
@zhangYiIntel
fix code in shape
a463fd1
@zhangYiIntel zhangYiIntel requested a review from jane-intel July 30, 2021 12:33
jane-intel
jane-intel requested changes Aug 3, 2021
View reviewed changes
ngraph/frontend/paddlepaddle/src/op/yolo_box.cpp Outdated Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/slice.cpp Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/range.cpp Outdated Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/shape.cpp Outdated Show resolved Hide resolved
ngraph/frontend/paddlepaddle/src/op/softmax.cpp Show resolved Hide resolved
@ilyachur ilyachur enabled auto-merge (squash) August 3, 2021 14:21
@ilyachur ilyachur merged commit 0aa6b07 into openvinotoolkit:master Aug 4, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@zhangYiIntel @mangguo321 @luo-cheng2021
[FrontEnd]enable pdpd ops conversion part3 (openvinotoolkit#6636)
e202c29 
* [FrontEnd]enable pdpd ops conversion part3

* Add adaptive pool2d op conversion (#1)

* param support tensor (#2)

* add missing sync_batch_norm

* Update pow.cpp

* deal empty axis (#5)

* deal empty axis

* apply review comments

* fix code style

* fix code style

* change shape to i32

* fix code in shape

* fix code style

* fix paddle code style

* remove redandent ops

* fix maxAdativePool

* fix expand_v2

* remove redandent code

Co-authored-by: Mang Guo <[email protected]>
Co-authored-by: Luo Cheng <[email protected]>
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@zhangYiIntel @mangguo321
@luo-cheng2021 @andrei-cv
[FrontEnd]enable pdpd ops conversion part3 (openvinotoolkit#6636)
854d61e 
* [FrontEnd]enable pdpd ops conversion part3

* Add adaptive pool2d op conversion (#1)

* param support tensor (#2)

* add missing sync_batch_norm

* Update pow.cpp

* deal empty axis (#5)

* deal empty axis

* apply review comments

* fix code style

* fix code style

* change shape to i32

* fix code in shape

* fix code style

* fix paddle code style

* remove redandent ops

* fix maxAdativePool

* fix expand_v2

* remove redandent code

Co-authored-by: Mang Guo <[email protected]>
Co-authored-by: Luo Cheng <[email protected]>
@luo-cheng2021 luo-cheng2021 mentioned this pull request Sep 7, 2021
Merged
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@zhangYiIntel @mangguo321
@luo-cheng2021 @akuporos
[FrontEnd]enable pdpd ops conversion part3 (openvinotoolkit#6636)
e7f300f 
* [FrontEnd]enable pdpd ops conversion part3

* Add adaptive pool2d op conversion (#1)

* param support tensor (#2)

* add missing sync_batch_norm

* Update pow.cpp

* deal empty axis (#5)

* deal empty axis

* apply review comments

* fix code style

* fix code style

* change shape to i32

* fix code in shape

* fix code style

* fix paddle code style

* remove redandent ops

* fix maxAdativePool

* fix expand_v2

* remove redandent code

Co-authored-by: Mang Guo <[email protected]>
Co-authored-by: Luo Cheng <[email protected]>
@zhangYiIntel zhangYiIntel deleted the yi3/frontend_pdpd_part3 branch July 25, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luo-cheng2021 luo-cheng2021 luo-cheng2021 left review comments

@jane-intel jane-intel jane-intel approved these changes

@mvafin mvafin mvafin approved these changes

@ilyachur ilyachur ilyachur approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@nosovmik nosovmik Awaiting requested review from nosovmik

@GlebKazantaev GlebKazantaev Awaiting requested review from GlebKazantaev

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
8 participants
@zhangYiIntel @ilyachur @nosovmik @ilya-lavrenov @mvafin @jane-intel @luo-cheng2021 @mangguo321