Migrate the unary OP visitor to typed template test. #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unaray OP list is :Floor, Log, Result, Sqrt, Squeeze. Signed-off-by: Luwei Zhou <[email protected]>
|
@lazarevevgeny @ilyachur @jdanieck Pls help to review. Thanks! |
ilyachur
reviewed
Jun 16, 2021
Signed-off-by: Luwei Zhou <[email protected]>
jdanieck
approved these changes
Jun 17, 2021
Signed-off-by: Luwei Zhou <[email protected]>
Merged
|
Need to upgrade this PR because PR with conflicted changes was merged #6124 |
Signed-off-by: Luwei Zhou <[email protected]>
|
@ilyachur , Merged with master and update with one commit. |
|
Seems most of the PR failed in the auto test. Is it possible to have this PR merged this week? Thanks! |
This was referenced Jun 21, 2021
yding10
added a commit
to yding10/openvino
that referenced
this pull request
Jun 22, 2021
ilyachur
pushed a commit
that referenced
this pull request
Jun 22, 2021
* change threshold to 20 instead of max limit of data type * add invalid input type test case * add invalid input data check * add input type dynamic check * add backend test case * add more clarity on spec and align with real implementation * Revert "[CPU] Fix for CoreThreadingTestsWithIterations tests (#5892)" This reverts commit 115aa14. * Revert "Revert "[CPU] Fix for CoreThreadingTestsWithIterations tests (#5892)"" This reverts commit 95afa50. * Revert "change threshold to 20 instead of max limit of data type" This reverts commit 91af825. * Revert "add more clarity on spec and align with real implementation" This reverts commit a3b232a. * add visitor attribute test case * Revert "add visitor attribute test case" This reverts commit 610728f. * add attribute test case * revise the attribute visitor test per parametrized visitor API PR: #6181
Merged
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…#6181) * Migrate the unary OP visitor to typed template test. The unaray OP list is :Floor, Log, Result, Sqrt, Squeeze. Signed-off-by: Luwei Zhou <[email protected]> * Add element precision type into GTEST typed parameter. Signed-off-by: Luwei Zhou <[email protected]> * Update the license to new version. Signed-off-by: Luwei Zhou <[email protected]> * Update the OP Ceiling visitor test to use unary typed template. Signed-off-by: Luwei Zhou <[email protected]>
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
…lkit#5938) * change threshold to 20 instead of max limit of data type * add invalid input type test case * add invalid input data check * add input type dynamic check * add backend test case * add more clarity on spec and align with real implementation * Revert "[CPU] Fix for CoreThreadingTestsWithIterations tests (openvinotoolkit#5892)" This reverts commit 115aa14. * Revert "Revert "[CPU] Fix for CoreThreadingTestsWithIterations tests (openvinotoolkit#5892)"" This reverts commit 95afa50. * Revert "change threshold to 20 instead of max limit of data type" This reverts commit 91af825. * Revert "add more clarity on spec and align with real implementation" This reverts commit a3b232a. * add visitor attribute test case * Revert "add visitor attribute test case" This reverts commit 610728f. * add attribute test case * revise the attribute visitor test per parametrized visitor API PR: openvinotoolkit#6181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unaray OP list is :Floor, Log, Result, Sqrt, Squeeze.
Signed-off-by: Luwei Zhou [email protected]
Details:
Tickets: