Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ngraph for AdaptivePool operations #6126

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Extend ngraph for AdaptivePool operations #6126

merged 1 commit into from
Jun 22, 2021

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Jun 10, 2021

Details:

  • Add AdaptiveMaxPool-8 and AdaptiveAvgPool-8 to ngraph

Tickets:

  • 56360

@mvafin mvafin requested review from a team, rkazants, sadolini and popovaan and removed request for a team June 10, 2021 10:44
@mvafin mvafin requested review from ilyachur and popovaan June 15, 2021 07:58
@mvafin mvafin requested review from a team and ilyachur June 20, 2021 22:18
ilyachur
ilyachur reviewed Jun 21, 2021
View reviewed changes
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you update oneDNN?

ngraph/test/visitors/op/adaptive_avg_pool.cpp Show resolved Hide resolved
ngraph/test/visitors/op/adaptive_max_pool.cpp Show resolved Hide resolved
@mvafin
Copy link
Contributor Author

mvafin commented Jun 21, 2021

Why did you update oneDNN?

I didn't and I don't see that in diff

@ilyachur
Copy link
Contributor

Why did you update oneDNN?

I didn't and I don't see that in diff

Looks like the incorrect git merge:
Screenshot 2021-06-22 at 09 30 09

@mvafin
Add ngraph shell for AdaptivePool operations
595ca32 
Apply review feedback

Fix code style

Add visitors tests

Check visitor for type attribute
@mvafin mvafin force-pushed the op/adaptive_pool/shell branch from 071faac to 595ca32 Compare June 22, 2021 08:11
@mvafin mvafin requested a review from ilyachur June 22, 2021 08:38
@ilyachur ilyachur merged commit 1bc18d8 into openvinotoolkit:master Jun 22, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@mvafin
Add ngraph shell for AdaptivePool operations (openvinotoolkit#6126)
d7c0577 
Apply review feedback

Fix code style

Add visitors tests

Check visitor for type attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popovaan popovaan popovaan approved these changes

@sadolini sadolini sadolini approved these changes

@ilyachur ilyachur ilyachur approved these changes

@rkazants rkazants Awaiting requested review from rkazants

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvafin @ilyachur @sadolini @popovaan