Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed performance drop for Interpolate-4 #4354

Merged
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
066daac
Commit.
vgavrilo Jul 30, 2020
c212c50
Merge remote-tracking branch 'upstream/master'
vgavrilo Jul 30, 2020
228af66
Merge remote-tracking branch 'upstream/master'
vgavrilo Aug 15, 2020
66b99ac
Merge remote-tracking branch 'upstream/master'
vgavrilo Aug 20, 2020
62b2452
Merge remote-tracking branch 'upstream/master'
vgavrilo Aug 26, 2020
dd5a343
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 1, 2020
146cfcb
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 2, 2020
11cfd32
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 2, 2020
f135fdc
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 4, 2020
14b3b49
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 11, 2020
29d798a
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 16, 2020
5aa69a3
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 16, 2020
3754f40
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 17, 2020
a211ce8
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 18, 2020
e7ae609
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 21, 2020
2ed2d5c
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 21, 2020
bdbfb81
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 25, 2020
29cfcfc
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 28, 2020
e64b285
Merge remote-tracking branch 'upstream/master'
vgavrilo Sep 29, 2020
ebf97c4
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 6, 2020
42de39d
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 13, 2020
88daad2
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 15, 2020
7084963
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 24, 2020
7f7de48
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 26, 2020
e58295d
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 28, 2020
429cf23
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 29, 2020
b9da719
Merge branch 'master' of https://github.com/vgavrilo/openvino
vgavrilo Oct 29, 2020
b9f8f9f
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 30, 2020
f61aef8
Merge remote-tracking branch 'upstream/master'
vgavrilo Oct 30, 2020
1b8a2c5
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 2, 2020
6676840
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 3, 2020
a317f50
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 9, 2020
c43795b
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 9, 2020
f55363c
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 10, 2020
ec40ea5
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 11, 2020
131eb6d
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 12, 2020
65f385f
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 16, 2020
d96448d
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 19, 2020
21716b2
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 20, 2020
f74d471
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 24, 2020
1608f4b
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 24, 2020
301148d
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 24, 2020
bc71ef8
Merge remote-tracking branch 'upstream/master'
vgavrilo Nov 26, 2020
a3261cd
Merge remote-tracking branch 'upstream/master'
vgavrilo Dec 1, 2020
748cef0
Merge remote-tracking branch 'upstream/master'
vgavrilo Dec 14, 2020
eabfc05
Merge remote-tracking branch 'upstream/master'
vgavrilo Dec 18, 2020
44dd347
Merge remote-tracking branch 'upstream/master'
vgavrilo Dec 23, 2020
4f979e0
Merge remote-tracking branch 'upstream/master'
vgavrilo Dec 25, 2020
3f1a97b
Merge remote-tracking branch 'upstream/master'
vgavrilo Dec 30, 2020
555f63c
Merge remote-tracking branch 'upstream/master'
vgavrilo Dec 31, 2020
f3d8290
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 11, 2021
2621b8c
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 14, 2021
ed5fe6f
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 19, 2021
cab4024
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 20, 2021
7fa0602
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 20, 2021
ecb6d7e
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 22, 2021
da6fd45
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 25, 2021
bbfbd86
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 26, 2021
3c9f309
Merge remote-tracking branch 'upstream/master'
vgavrilo Jan 30, 2021
592a3d2
Merge remote-tracking branch 'upstream/master'
vgavrilo Feb 2, 2021
89773e1
Merge remote-tracking branch 'upstream/master'
vgavrilo Feb 4, 2021
5d6d533
Merge remote-tracking branch 'upstream/master'
vgavrilo Feb 9, 2021
5ca972b
Merge remote-tracking branch 'upstream/master'
vgavrilo Feb 16, 2021
dcd6b57
Reverted fix in the nGraph conversion of Intepolate-1 into Interpolat…
vgavrilo Feb 16, 2021
9e48c25
Small fix.
vgavrilo Feb 16, 2021
dfa9e8e
Added comment.
vgavrilo Feb 16, 2021
8fbeefb
Merge remote-tracking branch 'upstream/master' into vgavrilo/performa…
vgavrilo Feb 16, 2021
ecaae6d
Added TODO.
vgavrilo Feb 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ ngraph::pass::ConvertInterpolate1ToInterpolate4::ConvertInterpolate1ToInterpolat
i++;
}

auto input_shape_rank = inp_partial_shape.rank().get_length();
auto scalesConstant = ngraph::op::Constant::create(ngraph::element::f32, {scales.size()}, scales);
auto axisConstant = ngraph::op::Constant::create(ngraph::element::i64, {attrsV0.axes.size()},
std::vector<std::size_t>{attrsV0.axes.begin(), attrsV0.axes.end()});
Expand All @@ -45,7 +46,20 @@ ngraph::pass::ConvertInterpolate1ToInterpolate4::ConvertInterpolate1ToInterpolat
if (attrsV0.mode == "nearest") {
attrsV4.mode = ngraph::opset4::Interpolate::InterpolateMode::nearest;
} else if (attrsV0.mode == "linear") {
attrsV4.mode = ngraph::opset4::Interpolate::InterpolateMode::linear;
vgavrilo marked this conversation as resolved.
Show resolved Hide resolved
// If we write only
// attrsV4.mode = ngraph::op::v4::Interpolate::InterpolateMode::linear;
// instead of a conditional statements below when attrsV0.mode == "linear",
// then we have a performance drop, because CPU and GPU have no optimized
// version of the 'linear' mode.
// TODO: delete this conditional statement, when CPU and GPU will have
// optimized version of the 'linear' mode.
if (input_shape_rank < 5) {
attrsV4.mode = ngraph::op::v4::Interpolate::InterpolateMode::linear_onnx;
} else if (input_shape_rank == 5) {
attrsV4.mode = ngraph::op::v4::Interpolate::InterpolateMode::linear;
} else {
return false;
}
} else if (attrsV0.mode == "cubic") {
attrsV4.mode = ngraph::opset4::Interpolate::InterpolateMode::cubic;
} else if (attrsV0.mode == "linear_onnx") {
Expand Down