[CPU][ARM] JIT Floor Mod Operation #27706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
reviewed
Nov 25, 2024
There was a problem hiding this comment.
@geeky33 Thank you for the contribution to OpenVINO! 👍🏼
Also, could you please launch CPU-specific tests using --gtest_filter='*EltwiseLayerCPUTest*FloorMod*'? These tests verify that JIT primitive with your emitter is used now.
I believe that there will be 0 such tests. Then we need to add them 😊
- Please, update the variable eltwiseOpTypesBinInp() in tests -
Floor_modshould be tested on x64/x86 platforms as before and on ARM64 machines too. If you do it and launch tests with the mentioned gtest filter above, the tests should be failed with error messageunexpected primitive type. - Please update the method getPrimitiveType - now it should return
jitforFloor_mod. After that, tests should be green 😃
src/plugins/intel_cpu/src/emitters/plugin/aarch64/jit_eltwise_emitters.cpp
Show resolved
Hide resolved
|
Hi @a-sidorova i have made a commit as you told me . |
a-sidorova
reviewed
Nov 28, 2024
src/plugins/intel_cpu/src/emitters/plugin/aarch64/jit_eltwise_emitters.cpp
Outdated
Show resolved
Hide resolved
added the aux register
|
build_jenkins |
|
build_jenkins |
|
build_jenkins |
a-sidorova
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
@a-sidorova can you please review the code ? :)
Tickets: