Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyOV] Restrict changing data in const #27431

Merged
merged 4 commits into from
Nov 13, 2024
Merged

[PyOV] Restrict changing data in const #27431

merged 4 commits into from
Nov 13, 2024

Conversation

akuporos
Copy link
Contributor

@akuporos akuporos commented Nov 6, 2024

Details:

  • Const op meant to be non-changeable

Tickets:

@akuporos akuporos requested a review from a team as a code owner November 6, 2024 11:22
@akuporos akuporos added this to the 2025.0 milestone Nov 6, 2024
@akuporos akuporos added category: Python API OpenVINO Python bindings bug Something isn't working labels Nov 6, 2024
@akuporos akuporos requested a review from KodiaqQ November 6, 2024 13:44
@akuporos akuporos requested a review from almilosz November 13, 2024 11:28
@akuporos akuporos force-pushed the akup/restrict-change-data-in-const branch from 5b64ee6 to 8a089ce Compare November 13, 2024 11:35
ilya-lavrenov
ilya-lavrenov approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as it's aligned with C++ - constants are immutable

@akuporos akuporos added this pull request to the merge queue Nov 13, 2024
Merged via the queue into openvinotoolkit:master with commit a0940bb Nov 13, 2024
166 checks passed
@akuporos akuporos deleted the akup/restrict-change-data-in-const branch November 13, 2024 14:37
NishantPrabhuFujitsu pushed a commit to NishantPrabhuFujitsu/openvino that referenced this pull request Nov 26, 2024
@akuporos @NishantPrabhuFujitsu
[PyOV] Restrict changing data in const (openvinotoolkit#27431)
b0f3d54 
### Details:
 - Const op meant to be non-changeable

### Tickets:
 - CVS-124319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almilosz almilosz almilosz approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@p-wysocki p-wysocki Awaiting requested review from p-wysocki

@praasz praasz Awaiting requested review from praasz

@KodiaqQ KodiaqQ Awaiting requested review from KodiaqQ

Assignees

@ilya-lavrenov ilya-lavrenov

@praasz praasz

@almilosz almilosz

Labels
bug Something isn't working category: Python API OpenVINO Python bindings
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
4 participants
@akuporos @ilya-lavrenov @almilosz @praasz