Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF FE] Add complex type support for rank op #23118

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

AsakusaRinne
Copy link
Collaborator

Details:

  • Add complex type support for rank op
  • Add corresponding test of it

Tickets:

  • I think I don't have a ticket id

Related issues

#22956

@AsakusaRinne AsakusaRinne requested a review from a team as a code owner February 27, 2024 18:03
@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Feb 27, 2024
@AsakusaRinne
Copy link
Collaborator Author

AsakusaRinne commented Feb 27, 2024

@rkazants Hi Roman, It's glad to have a chance to contribute! I'm a student who wants to participate in GSoC2024 of openvino.

I met a problem in this PR and I didn't find a solution after searching in issues and other PRs. Here's the error message, which is also mentioned in #22952 (comment). Could you please help to take a look of it?

E       openvino._pyopenvino.OpConversionFailure: Check 'is_conversion_successful' failed at src/frontends/tensorflow/src/frontend.cpp:434:
E       FrontEnd API failed with OpConversionFailure:
E       [TensorFlow Frontend] Internal error, no translator found for operation(s): ComplexTypeMark
E       To facilitate the conversion of unsupported operations, refer to Frontend Extension documentation: https://docs.openvino.ai/latest/openvino_docs_Extensibility_UG_Frontend_Extensions.html

/home/rinne/miniconda3/envs/openvino-dev/lib/python3.9/site-packages/openvino/frontend/frontend.py:21: OpConversionFailure

Besides, I followed your instruction in another issue to view the pb model generated in the test but there isn't anything seemed odd to me.
`M7)EM@ B97VRB 6GOQ N8F

src/frontends/tensorflow_common/src/op/rank.cpp Outdated Show resolved Hide resolved
src/frontends/tensorflow_common/src/op/rank.cpp Outdated Show resolved Hide resolved
src/frontends/tensorflow_common/src/op/rank.cpp Outdated Show resolved Hide resolved
@rkazants
Copy link
Contributor

build_jenkins

@AsakusaRinne
Copy link
Collaborator Author

@rkazants The past ci failed at clang-format check and I've updated it. Could you please approve the workflows again?

@rkazants
Copy link
Contributor

rkazants commented Mar 1, 2024

build_jenkins

@rkazants rkazants enabled auto-merge March 1, 2024 09:00
@rkazants rkazants added this to the 2024.1 milestone Mar 1, 2024
@rkazants rkazants added this pull request to the merge queue Mar 1, 2024
Merged via the queue into openvinotoolkit:master with commit 7d35d2a Mar 1, 2024
107 checks passed
@rkazants rkazants linked an issue Mar 1, 2024 that may be closed by this pull request
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
### Details:
 - Add complex type support for rank op
 - Add corresponding test of it

### Tickets:
 - I think I don't have a ticket id

### Related issues

openvinotoolkit#22956

---------

Co-authored-by: Roman Kazantsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][TF FE]: Support complex tensors for Rank operation
2 participants