MatrixBandPart operation for TensorFlow Hub models #22447

himanshugupta11002 · 2024-01-26T08:44:55Z

Details:

Implement the corresponding loader into op directory and named as matrix_band_part.cpp
- according to hints given I was find the sizes m and n of two last dimension of input and generate ranges [0, m) and [0, n).
  Unsqueeze these ranges so that to have tensor of shapes [m, 1] and [1, n]
Register it into the dictionary of loaders
Then apply the logical operations
Implement the layer test for this operation

Problem when I am running on Codespaces it give me so many errors on which I am currently working on.

Tickets:

[Good First Issue][TF FE]: Support MatrixBandPart operation for TensorFlow Hub models #22081

rkazants · 2024-01-26T08:46:57Z

build_jenkins

rkazants

@himanshugupta11002, please update https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/tensorflow/docs/supported_ops.md documentation. It is recently added new check. Without it, Ci will fail.

himanshugupta11002 · 2024-01-26T08:57:33Z

okay I'll update it

rkazants · 2024-01-31T06:14:27Z

okay I'll update it

Hi @himanshugupta11002, any update on the fix? It should be very easy:)
Please do not delay.

Best regards,
Roman

rkazants · 2024-02-02T06:16:20Z

build_jenkins

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp

rkazants

Please apply code formatting

rkazants

please apply comment. code-formatting is not yet applied

rkazants · 2024-02-12T06:45:02Z

build_jenkins

rkazants · 2024-02-12T09:39:18Z

Hi @himanshugupta11002,

can you please apply comments asap because we have code freeze for 2024.0 release tomorrow and your PR is highly recommended to be included?

Best regards,
Roman

rkazants · 2024-02-13T07:15:26Z

build_jenkins

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp

rkazants · 2024-02-19T16:12:15Z

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp

+            make_shared<v1::Less>(make_shared<v1::Constant>(element::i64, Shape{}, {num_lower}), make_shared<v1::Constant>(element::i64, Shape{}, {0})),
+            make_shared<v1::LessEqual>(make_shared<v1::Subtract>(m, n), make_shared<v1::Constant>(element::i64, Shape{}, {num_lower}))
+        ),
+        make_shared<v1::LogicalOr>(
+            make_shared<v1::Less>(make_shared<v1::Constant>(element::i64, Shape{}, {num_upper}), make_shared<v1::Constant>(element::i64, Shape{}, {0})),


Please fix num_lower and num_upper usage here as well.

rkazants · 2024-02-19T16:13:12Z

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp

+        ),
+        make_shared<v1::LogicalOr>(
+            make_shared<v1::Less>(make_shared<v1::Constant>(element::i64, Shape{}, {num_upper}), make_shared<v1::Constant>(element::i64, Shape{}, {0})),
+            make_shared<v1::LessEqual>(make_shared<v1::Subtract>(n, m), make_shared<v1::Constant>(element::i64, Shape{}, {num_upper}))


num_upper in Constant

rkazants · 2024-02-21T08:38:32Z

Hi @himanshugupta11002, pls address comments above. I believe your PR is close to completeness.

Best regards,
Roman

himanshugupta11002 · 2024-02-23T19:09:54Z

Hi @rkazants, should I add comments in the matrixbandpart.cpp file, or should I add them in all files where I have made changes?

rkazants · 2024-02-26T07:23:25Z

tools/mo/unit_tests/moc_tf_fe/test_models/model_fp32.frozen

please revert this change

@himanshugupta11002, can you please revert this asap? That is because it is blocking to merge PR and to enable StableDiffusion model from Keras.

rkazants · 2024-02-26T07:23:36Z

tools/ovc/unit_tests/moc_tf_fe/test_models/model_fp32.frozen

please revert this change

rkazants · 2024-02-26T13:47:26Z

Hi @himanshugupta11002, I am closing this PR. I fix your implementation there: #23082. Your contribution is preserved there.
I did so because we urgently need this translator for Keras StableDiffusion model support.

Best regards,
Roman

**Details:** `MatrixBandPart` is needed to support Keras StableDiffusion model. This is reserved PR for #22447 **Ticket:** CVS-133786 --------- Signed-off-by: Kazantsev, Roman <[email protected]> Co-authored-by: himanshugupta11002 <[email protected]>

himanshugupta11002 added 7 commits January 16, 2024 00:53

Create MatrixBandPart.cpp

8165924

Delete src/frontends/tensorflow_common/src/op/MatrixBandPart.cpp

d1abc7d

Create matrix_band_part.cpp

a0af6d6

Update op_table.cpp

c76cdbf

Update matrix_band_part.cpp

d3b0f9c

Update matrix_band_part.cpp

57a7629

Create test_tf_MatrixBandPart.py

1efcaaa

himanshugupta11002 requested a review from a team as a code owner January 26, 2024 08:44

github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Jan 26, 2024

rkazants self-assigned this Jan 26, 2024

rkazants linked an issue Jan 26, 2024 that may be closed by this pull request

[Good First Issue][TF FE]: Support MatrixBandPart operation for TensorFlow Hub models #22081

Closed

rkazants reviewed Jan 26, 2024

View reviewed changes

rkazants added the ExternalIntelPR External contributor from Intel label Jan 26, 2024

rkazants added this to the 2024.0 milestone Jan 26, 2024

himanshugupta11002 added 2 commits February 2, 2024 01:36

Merge branch 'master' into master

dd1dbd1

Update supported_ops.md

74300ea

himanshugupta11002 requested a review from a team as a code owner February 1, 2024 20:11

himanshugupta11002 requested review from zKulesza and removed request for a team February 1, 2024 20:11

github-actions bot added the category: docs OpenVINO documentation label Feb 1, 2024

Merge branch 'master' into master

c4c7e2e

rkazants reviewed Feb 3, 2024

View reviewed changes

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp Show resolved Hide resolved

rkazants reviewed Feb 3, 2024

View reviewed changes

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp Outdated Show resolved Hide resolved

rkazants reviewed Feb 3, 2024

View reviewed changes

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp Show resolved Hide resolved

rkazants reviewed Feb 3, 2024

View reviewed changes

rkazants reviewed Feb 12, 2024

View reviewed changes

Apply suggestions from code review

24d3ed9

Update matrix_band_part.cpp

184b0a5

rkazants reviewed Feb 13, 2024

View reviewed changes

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp Outdated Show resolved Hide resolved

rkazants reviewed Feb 13, 2024

View reviewed changes

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp Show resolved Hide resolved

himanshugupta11002 and others added 2 commits February 13, 2024 09:29

added in_band(m,n) conditions

97d62ab

Update src/frontends/tensorflow_common/src/op/matrix_band_part.cpp

95b62b6

rkazants reviewed Feb 14, 2024

View reviewed changes

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp Show resolved Hide resolved

Update matrix_band_part.cpp

08d4983

rkazants reviewed Feb 16, 2024

View reviewed changes

src/frontends/tensorflow_common/src/op/matrix_band_part.cpp Outdated Show resolved Hide resolved

update constant part

bea6081

rkazants reviewed Feb 19, 2024

View reviewed changes

rkazants modified the milestones: 2024.0, 2024.1 Feb 21, 2024

created sepeerate variable for zero

9f2881b

himanshugupta11002 added 2 commits February 25, 2024 13:43

Merge branch 'master' into master

bcd97c2

comments added

64c0150

rkazants reviewed Feb 26, 2024

View reviewed changes

tools/ovc/unit_tests/moc_tf_fe/test_models/model_fp32.frozen Outdated

Copy link

Contributor

rkazants Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change

rkazants mentioned this pull request Feb 26, 2024

[TF FE] MatrixBandPart operation for TensorFlow Hub models #23082

Merged

Merge branch 'master' into master

69a03b0

rkazants closed this Feb 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MatrixBandPart operation for TensorFlow Hub models #22447

MatrixBandPart operation for TensorFlow Hub models #22447

himanshugupta11002 commented Jan 26, 2024

rkazants commented Jan 26, 2024

rkazants left a comment •

edited

Loading

himanshugupta11002 commented Jan 26, 2024

rkazants commented Jan 31, 2024

rkazants commented Feb 2, 2024

rkazants left a comment

rkazants left a comment

rkazants commented Feb 12, 2024

rkazants commented Feb 12, 2024

rkazants commented Feb 13, 2024

rkazants Feb 19, 2024

rkazants Feb 19, 2024 •

edited

Loading

rkazants commented Feb 21, 2024

himanshugupta11002 commented Feb 23, 2024

rkazants Feb 26, 2024

rkazants Feb 26, 2024 •

edited

Loading

rkazants Feb 26, 2024

rkazants commented Feb 26, 2024

MatrixBandPart operation for TensorFlow Hub models #22447

MatrixBandPart operation for TensorFlow Hub models #22447

Conversation

himanshugupta11002 commented Jan 26, 2024

Details:

Tickets:

rkazants commented Jan 26, 2024

rkazants left a comment • edited Loading

Choose a reason for hiding this comment

himanshugupta11002 commented Jan 26, 2024

rkazants commented Jan 31, 2024

rkazants commented Feb 2, 2024

rkazants left a comment

Choose a reason for hiding this comment

rkazants left a comment

Choose a reason for hiding this comment

rkazants commented Feb 12, 2024

rkazants commented Feb 12, 2024

rkazants commented Feb 13, 2024

rkazants Feb 19, 2024

Choose a reason for hiding this comment

rkazants Feb 19, 2024 • edited Loading

Choose a reason for hiding this comment

rkazants commented Feb 21, 2024

himanshugupta11002 commented Feb 23, 2024

rkazants Feb 26, 2024

Choose a reason for hiding this comment

rkazants Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

rkazants Feb 26, 2024

Choose a reason for hiding this comment

rkazants commented Feb 26, 2024

rkazants left a comment •

edited

Loading

rkazants Feb 19, 2024 •

edited

Loading

rkazants Feb 26, 2024 •

edited

Loading