Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snippets][Doc] Updated the design guide #22258

Merged

Conversation

a-sidorova
Copy link
Contributor

@a-sidorova a-sidorova commented Jan 19, 2024

Details:

  • Refactored stages about data flow and control flow
  • Added information about positioned passes for backend-specific pass registration
  • Added information about insert_node and replace_with_node helpers
  • Updated about LinearIR serialization methodsy
  • Added more information about Buffer management
  • Updated generator passes description

Tickets:

  • N/A

TODO

  • PerfCounters, segfaul detectors ?

@a-sidorova a-sidorova requested a review from a team as a code owner January 19, 2024 09:54
@a-sidorova a-sidorova requested review from akopytko and removed request for a team January 19, 2024 09:54
@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: docs OpenVINO documentation labels Jan 19, 2024
@a-sidorova a-sidorova force-pushed the feature/snippets/docs/update branch from 29a8d5f to fee8ef2 Compare January 19, 2024 10:54
@a-sidorova a-sidorova added this to the 2024.0 milestone Jan 19, 2024
@a-sidorova
Copy link
Contributor Author

@v-Golubev @IvanNovoselov guys, may I ask you to take a look at the doc updates please?

Copy link
Contributor

@v-Golubev v-Golubev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-sidorova
Copy link
Contributor Author

@IvanNovoselov could you take a look please?

src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
src/common/snippets/docs/snippets_design_guide.md Outdated Show resolved Hide resolved
@a-sidorova a-sidorova force-pushed the feature/snippets/docs/update branch from fee8ef2 to bf1875e Compare February 9, 2024 11:50
@a-sidorova
Copy link
Contributor Author

@v-Golubev @IvanNovoselov thanks for the review, guys!

@dmitry-gorokhov could you review as well please?

@a-sidorova a-sidorova modified the milestones: 2024.0, 2024.1 Feb 19, 2024
The second one allows users to serialize the `LIR` in two representations: as a control flow graph of `LinearIR` using the pass `SerializeControlFlow` and
as a data flow graph of `LinearIR` using the pass `SerializeDataFlow` (control flow operations (e.g. `LoopBegin`/`LoopEnd`) are not serialized).
The both serializations are saved in `xml` OpenVINO graph format, where a lot of useful parameters are displayed for every `Expression`.
Please see [perf_count.md](./debug_capabilities/perf_count.md) and [snippets_segfault_detector.md](./debug_capabilities/snippets_segfault_detector.md) for more info regarding the performance counters and segfault detector.
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Feb 27, 2024
Merged via the queue into openvinotoolkit:master with commit 0ef2fab Feb 27, 2024
70 checks passed
@dmitry-gorokhov dmitry-gorokhov deleted the feature/snippets/docs/update branch February 27, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin category: docs OpenVINO documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants