Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snippets] Specific loop iterations handler #21303

Merged
merged 1 commit into from
Feb 27, 2024
Merged

[Snippets] Specific loop iterations handler #21303

merged 1 commit into from
Feb 27, 2024

Conversation

v-Golubev
Copy link
Contributor

@v-Golubev v-Golubev commented Nov 27, 2023 •
edited
Loading

Details:

  • Introduced loop handlers which define how to handle first/last loop iteration
  • Changed loop markup logic: loops with increment > work_amount are not created anymore: in this case increment is set equal to work_amount

Tickets:

Prerequisites:

@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: CPU OpenVINO CPU plugin category: build OpenVINO cmake script / infra labels Nov 27, 2023
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch 3 times, most recently from c04b197 to 23f3367 Compare November 27, 2023 20:37
@github-actions github-actions bot removed the category: build OpenVINO cmake script / infra label Nov 27, 2023
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch 3 times, most recently from 82b5294 to ac308cf Compare December 6, 2023 10:51
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch from 0a79628 to 3a4c7fb Compare December 6, 2023 13:28
@v-Golubev v-Golubev marked this pull request as ready for review December 6, 2023 18:44
@v-Golubev v-Golubev requested review from a team as code owners December 6, 2023 18:44
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch 2 times, most recently from 23e3045 to f6f4fd9 Compare December 8, 2023 09:55
@github-actions github-actions bot removed the category: IE Tests OpenVINO Test: plugins and common label Dec 8, 2023
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch from f6f4fd9 to a5fbd75 Compare December 14, 2023 15:57
@v-Golubev v-Golubev mentioned this pull request Dec 14, 2023
Merged
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch 5 times, most recently from b2dec7d to 6d88e63 Compare December 21, 2023 08:33
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch 2 times, most recently from ba609fa to 2ec7fd8 Compare December 22, 2023 10:13
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch from 09b5188 to c175d24 Compare January 24, 2024 14:39
@v-Golubev v-Golubev mentioned this pull request Jan 25, 2024
Closed
@a-sidorova
Copy link
Contributor

Also I'd like to remind that we decided to update the documentation with changes.
May I ask you to add new information please to the file when the #22258 is merged? It'd be really great!

@v-Golubev
Copy link
Contributor Author

Also I'd like to remind that we decided to update the documentation with changes. May I ask you to add new information please to the file when the #22258 is merged? It'd be really great!

Yes, the documentation must be updated, thanks for the reminder. I don't do that in this PR to avoid potential merge conflicts with #22258

a-sidorova
a-sidorova approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@a-sidorova a-sidorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

IvanNovoselov
IvanNovoselov approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@IvanNovoselov IvanNovoselov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch from 862fb05 to 526e41c Compare January 31, 2024 09:00
@v-Golubev
Copy link
Contributor Author

@a-sidorova @IvanNovoselov Thanks a lot for the review! @dmitry-gorokhov could you please take a look?

@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch 2 times, most recently from 93fe7d4 to 8734e0e Compare February 1, 2024 11:13
@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch from 017cd45 to b217662 Compare February 8, 2024 17:33
dmitry-gorokhov
dmitry-gorokhov approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from functional perspective.
As a follow-up task we need to update documentaion as long as this PR introduce some fundamental functionality that should be properly described.

@v-Golubev v-Golubev force-pushed the vg/snippets/first_last_iteration_handler branch from 0ba2d94 to 4f44c34 Compare February 26, 2024 20:16
@dmitry-gorokhov dmitry-gorokhov added this to the 2024.1 milestone Feb 27, 2024
@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Feb 27, 2024
Merged via the queue into openvinotoolkit:master with commit 1f88f2e Feb 27, 2024
101 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Mar 8, 2024
@v-Golubev
[Snippets] SoftmaxDecomposition is moved to data flow pipeline (#21672)
b068ea2 
### Details:
 - *Control flow pass `SoftmaxDecomposition` removed*
- *Introduced data flow `SoftmaxDecomposition` pass which decomposes
`Softmax` operation to a sequence of `Eltwise` ops + `Reduce` ops*
- *Introduced control flow `ReduceDecomposition` pass which decomposes
Reduce operation to a range of low-level operations on linear IR.
Limitation: only reduction by last dimension is supported*

### Tickets:
 - *CVS-112847*

### Prerequisites:
- #21303 

PR between branches for review (all the review discussions are there):
[Softmax decomposition moved to data flow
pipeline](v-Golubev#24 (comment))
vishniakov-nikolai pushed a commit to vishniakov-nikolai/openvino that referenced this pull request Mar 13, 2024
@v-Golubev @vishniakov-nikolai
[Snippets] SoftmaxDecomposition is moved to data flow pipeline (openv…
9baf753 
…inotoolkit#21672)

### Details:
 - *Control flow pass `SoftmaxDecomposition` removed*
- *Introduced data flow `SoftmaxDecomposition` pass which decomposes
`Softmax` operation to a sequence of `Eltwise` ops + `Reduce` ops*
- *Introduced control flow `ReduceDecomposition` pass which decomposes
Reduce operation to a range of low-level operations on linear IR.
Limitation: only reduction by last dimension is supported*

### Tickets:
 - *CVS-112847*

### Prerequisites:
- openvinotoolkit#21303 

PR between branches for review (all the review discussions are there):
[Softmax decomposition moved to data flow
pipeline](v-Golubev#24 (comment))
github-merge-queue bot pushed a commit that referenced this pull request Apr 22, 2024
@IvanNovoselov @egeor
[Snippets] TPP FP32 MHA support (#22210)
e563109 
### Details:
 - *Enable FP32 MHA lowering using TPP backend*
- *This PR is a productization of the [TPP integration
POC](#20956
### Prerequisites:
- #21303
- #21672

Branch to Branch PR in to review the changes before the Prerequisites
are merged: IvanNovoselov#18

---------

Co-authored-by: egeorgan <[email protected]>
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@v-Golubev @alvoron
[Snippets] SoftmaxDecomposition is moved to data flow pipeline (openv…
4112800 
…inotoolkit#21672)

### Details:
 - *Control flow pass `SoftmaxDecomposition` removed*
- *Introduced data flow `SoftmaxDecomposition` pass which decomposes
`Softmax` operation to a sequence of `Eltwise` ops + `Reduce` ops*
- *Introduced control flow `ReduceDecomposition` pass which decomposes
Reduce operation to a range of low-level operations on linear IR.
Limitation: only reduction by last dimension is supported*

### Tickets:
 - *CVS-112847*

### Prerequisites:
- openvinotoolkit#21303 

PR between branches for review (all the review discussions are there):
[Softmax decomposition moved to data flow
pipeline](v-Golubev#24 (comment))
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@IvanNovoselov @egeor @alvoron
[Snippets] TPP FP32 MHA support (openvinotoolkit#22210)
e0b9331 
### Details:
 - *Enable FP32 MHA lowering using TPP backend*
- *This PR is a productization of the [TPP integration
POC](openvinotoolkit#20956
### Prerequisites:
- openvinotoolkit#21303
- openvinotoolkit#21672

Branch to Branch PR in to review the changes before the Prerequisites
are merged: IvanNovoselov#18

---------

Co-authored-by: egeorgan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-sidorova a-sidorova a-sidorova approved these changes

@IvanNovoselov IvanNovoselov IvanNovoselov approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin no_stale Do not mark as stale
Projects
None yet
Milestone
2024.1
Development

Successfully merging this pull request may close these issues.
4 participants
@v-Golubev @a-sidorova @dmitry-gorokhov @IvanNovoselov