Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid DOWNLOAD_EXTRACT_TIMESTAMP warning #22135

Merged
merged 4 commits into from
Jan 13, 2024
Merged

Avoid DOWNLOAD_EXTRACT_TIMESTAMP warning #22135

merged 4 commits into from
Jan 13, 2024

Conversation

vishniakov-nikolai
Copy link
Contributor

Problem with FetchContent appears in CI:

CMake Warning (dev) at /mnt/vcpkg-ci/downloads/tools/cmake-3.27.1-linux/cmake-3.27.1-linux-x86_64/share/cmake-3.27/Modules/FetchContent.cmake:1316 (message):
  The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
  not set.  The policy's OLD behavior will be used.  When using a URL
  download, the timestamps of extracted files should preferably be that of
  the time of extraction, otherwise code that depends on the extracted
  contents might not be rebuilt if the URL changes.  The OLD behavior
  preserves the timestamps from the archive instead, but this is usually not
  what you want.  Update your project to the NEW behavior or specify the
  DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
  robustness issue.
Call Stack (most recent call first):
  src/bindings/js/node/CMakeLists.txt:35 (FetchContent_Declare)

This fix should avoid this warning.

Details:

  • item1
  • ...

Tickets:

  • ticket-id

@vishniakov-nikolai vishniakov-nikolai requested a review from a team as a code owner January 12, 2024 14:52
@github-actions github-actions bot added the category: build OpenVINO cmake script / infra label Jan 12, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2024.0 milestone Jan 12, 2024
@ilya-lavrenov ilya-lavrenov added the port to 2023.3 Need port from master to 2023.3 LTS label Jan 12, 2024
ilya-lavrenov
ilya-lavrenov reviewed Jan 12, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov enabled auto-merge (squash) January 12, 2024 14:58
@ilya-lavrenov ilya-lavrenov merged commit e7791d4 into openvinotoolkit:master Jan 13, 2024
99 checks passed
@vishniakov-nikolai vishniakov-nikolai deleted the fix/fetch-content-policy branch January 13, 2024 21:32
@ilya-lavrenov ilya-lavrenov mentioned this pull request Jan 16, 2024
Merged
@ilya-lavrenov ilya-lavrenov removed the port to 2023.3 Need port from master to 2023.3 LTS label Jan 19, 2024
ilya-lavrenov added a commit that referenced this pull request Jan 19, 2024
@ilya-lavrenov @akashchi
@vishniakov-nikolai @fredrickomondi @SANTHOSH-MAMIDISETTI @p-wysocki @rkazants @ababushk
Ported changes from master (#22193)
d19307b 
* [CI] [GHA] Introduce JS API as a part of the existing workflows (#21898)

* add js api to linux

* try inside the ov repo

* use rel path

* use a separate job for js api

* correct command formatting

* add missing var

* use spacing

* mv js building

* add node installing

* add to windows

* check pwsh and cmd running npm

* add smart CI conditions; disable for win

* use node version as env var

* extract js job into a separate workflow, add to other *nix

* fix input name

* Activate js bindings tests for arm64

* upload ov js package

* correct formatting

* add missing syntax

---------

Co-authored-by: Vishniakov Nikolai <[email protected]>

* Cmake Python build option flags should be added to the command in step #3 not step #4. I fixed the typo (#21993)

* [CI] [GHA] [JS API] Remove explicit default values settings in Linux ARM64 `cmake` (#22019)

* rm explicit default values settings

* Activate mac arm64 js api check

* Specify test run

---------

Co-authored-by: Vishniakov Nikolai <[email protected]>

* [OV JS] Activate validation for mac x86 (#22035)

* Extend validation for mac x86

* Remove extra params

* fixed broken doc links (#22088)

Co-authored-by: Przemyslaw Wysocki <[email protected]>

* [GHA] Update MO deps (#22130)

* [GHA] Update MO deps

Signed-off-by: Kazantsev, Roman <[email protected]>

* Update .github/components.yml

---------

Signed-off-by: Kazantsev, Roman <[email protected]>

* Avoid DOWNLOAD_EXTRACT_TIMESTAMP warning (#22135)

* Avoid DOWNLOAD_EXTRACT_TIMESTAMP warning

* Change applying policy condition

Co-authored-by: Ilya Lavrenov <[email protected]>

---------

Co-authored-by: Ilya Lavrenov <[email protected]>

* Fixed API validator search (#22136)

* [OV JS] Conditional enabling of JS API (#22139)

* Disable js api building for vcpkg

* Disable JS API by default

* Add disable JS API conditions in features.cmake

* Update cmake/features.cmake

* Update src/bindings/js/CMakeLists.txt

---------

Co-authored-by: Ilya Lavrenov <[email protected]>

* Fixed GHSA-h5c8-rqwp-cp95 (#22159)

* [PyOV][SAMPLES] Fix bugbear issue B038 (#22183)

* Fixed compilation on GHA CI

* Decrease number of workers for ONNX Model tests to prevent OOM kills (#22243)

* Decrease number of workers for ONNX Model tests to prevent OOM kills

* Try to use "-n auto" also

---------

Signed-off-by: Kazantsev, Roman <[email protected]>
Co-authored-by: Andrei Kashchikhin <[email protected]>
Co-authored-by: Vishniakov Nikolai <[email protected]>
Co-authored-by: fredrickomondi <[email protected]>
Co-authored-by: Santhosh Mamidisetti <[email protected]>
Co-authored-by: Przemyslaw Wysocki <[email protected]>
Co-authored-by: Roman Kazantsev <[email protected]>
Co-authored-by: Jan Iwaszkiewicz <[email protected]>
Co-authored-by: Andrey Babushkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: build OpenVINO cmake script / infra
Projects
None yet
Milestone
2024.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vishniakov-nikolai @ilya-lavrenov